On Sat, Mar 28, 2015 at 09:40:05PM +0100, Richard Weinberger wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index 1249f91..c955976 100644
> > --- a/drivers/staging/speakup/main.c
> > +++ b/drivers/staging/speakup/main.c
> > @@ -423,7 +423,8 @@ static
On Sat, Mar 28, 2015 at 05:26:34PM -0700, Shirish Gajera wrote:
> On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote:
> > //richard
>
> Are you sure you want me to do this changes. Because it will conflict
> the things written on http://kernelnewbies.org/
where is the conflict?
On Sat, Mar 28, 2015 at 09:40:05PM +0100, Richard Weinberger wrote:
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 1249f91..c955976 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -423,7 +423,8 @@ static void
On Sat, Mar 28, 2015 at 05:26:34PM -0700, Shirish Gajera wrote:
On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote:
//richard
Are you sure you want me to do this changes. Because it will conflict
the things written on http://kernelnewbies.org/
where is the conflict? you
Am 29.03.2015 um 01:26 schrieb Shirish Gajera:
> Are you sure you want me to do this changes. Because it will conflict
> the things written on http://kernelnewbies.org/
Conflict with what?
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
Am 29.03.2015 um 01:26 schrieb Shirish Gajera:
Are you sure you want me to do this changes. Because it will conflict
the things written on http://kernelnewbies.org/
Conflict with what?
Thanks,
//richard
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote:
> Am 29.03.2015 um 00:44 schrieb Shirish Gajera:
> > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
> >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> >>> Am 28.03.2015 um 22:18 schrieb Joe Perches:
Am 29.03.2015 um 00:44 schrieb Shirish Gajera:
> On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
>> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
>>> Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> On
On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> > Am 28.03.2015 um 22:18 schrieb Joe Perches:
> > > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> > >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
>
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
> Am 28.03.2015 um 22:18 schrieb Joe Perches:
> > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
> >> wrote:
> >>> This patch fixes the checkpatch.pl warning:
[]
> >>
Am 28.03.2015 um 22:18 schrieb Joe Perches:
> On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
>> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
>> wrote:
>>> This patch fixes the checkpatch.pl warning:
>
> []
>
>>> diff --git a/drivers/staging/speakup/main.c
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
> wrote:
> > This patch fixes the checkpatch.pl warning:
[]
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
> > @@ -423,7 +423,8 @@ static void
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: line over 80 characters
>
> All line over 80 characters in driver/staging/speakup/* are fixed.
>
> Signed-off-by: Shirish Gajera
> ---
> drivers/staging/speakup/main.c | 9
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed.
Signed-off-by: Shirish Gajera
---
drivers/staging/speakup/main.c | 9 ++---
drivers/staging/speakup/serialio.h | 3 ++-
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera gshirishf...@gmail.com wrote:
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed.
Signed-off-by: Shirish Gajera gshirishf...@gmail.com
---
Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera gshirishf...@gmail.com
wrote:
This patch fixes the checkpatch.pl warning:
[]
diff --git a/drivers/staging/speakup/main.c
On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote:
Am 29.03.2015 um 00:44 schrieb Shirish Gajera:
On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat,
On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera
Am 29.03.2015 um 00:44 schrieb Shirish Gajera:
On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote:
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
On Sat, Mar 28,
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed.
Signed-off-by: Shirish Gajera gshirishf...@gmail.com
---
drivers/staging/speakup/main.c | 9 ++---
drivers/staging/speakup/serialio.h
On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote:
Am 28.03.2015 um 22:18 schrieb Joe Perches:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera gshirishf...@gmail.com
wrote:
This patch fixes the checkpatch.pl warning:
On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote:
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera gshirishf...@gmail.com
wrote:
This patch fixes the checkpatch.pl warning:
[]
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
[]
@@ -423,7 +423,8 @@
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: line over 80 characters
>
> All line over 80 characters in driver/staging/speakup/* are fixed
>
> Signed-off-by: Shirish Gajera
> ---
> drivers/staging/speakup/main.c
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed
Signed-off-by: Shirish Gajera gajerashir...@gmail.com
---
On Mon, Jan 19, 2015 at 12:00:34PM -0800, shirish gajera wrote:
> I am confuse whether to wait till the patch got accepted or submit new
> patch set.
Just wait for Greg to get to the patch. We pretty much always apply
long line fixes so just assume it's going to merged.
>
> Also, how to
On Sun, Jan 18, 2015 at 09:55:50AM +, Ben Hutchings wrote:
> On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
> > This patch fixes the checkpatch.pl warning:
> >
> > WARNING: line over 80 characters
> >
> > All line over 80 characters in driver/staging/speakup/* are fixed
> [...]
>
Generally this patch is fine. There were a couple places which weren't
perfect.
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) {
> + synth_printf("%s\n",
> + spk_msg_get(MSG_EDGE_MSGS_START + msg_id
On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
> On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> > index e9f0c15..141abb7 100644
> > --- a/drivers/staging/speakup/main.c
> > +++
On Sun, Jan 18, 2015 at 09:29:21AM +0100, Robin Schroer wrote:
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index e9f0c15..141abb7 100644
--- a/drivers/staging/speakup/main.c
+++
On Sun, Jan 18, 2015 at 09:55:50AM +, Ben Hutchings wrote:
On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed
[...]
It is not
Generally this patch is fine. There were a couple places which weren't
perfect.
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
+ if ((spk_bleeps 2) (msg_id edge_quiet)) {
+ synth_printf(%s\n,
+ spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1));
+
On Mon, Jan 19, 2015 at 12:00:34PM -0800, shirish gajera wrote:
I am confuse whether to wait till the patch got accepted or submit new
patch set.
Just wait for Greg to get to the patch. We pretty much always apply
long line fixes so just assume it's going to merged.
Also, how to identify
On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: line over 80 characters
>
> All line over 80 characters in driver/staging/speakup/* are fixed
[...]
It is not important to fix all such warnings. The code seems perfectly
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index e9f0c15..141abb7 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -422,8 +422,10 @@ static void
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index e9f0c15..141abb7 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -422,8 +422,10 @@ static void
On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed
[...]
It is not important to fix all such warnings. The code seems perfectly
readable as
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed
Signed-off-by: Shirish Gajera
---
drivers/staging/speakup/main.c | 12
drivers/staging/speakup/serialio.h | 3 ++-
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
All line over 80 characters in driver/staging/speakup/* are fixed
Signed-off-by: Shirish Gajera gajerashir...@gmail.com
---
drivers/staging/speakup/main.c | 12
38 matches
Mail list logo