Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 05:14:41PM +0530, navin patidar wrote: > for usbip_host event_handler() handles following events. defined > in "usbip_common.h" > > 1. SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) > 2. SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN |

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

for usbip_host event_handler() handles following events. defined in "usbip_common.h" 1. SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) 2. SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) 3. SDEV_EVENT_ERROR_TCP(USBIP_EH_SHUTDOWN |

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 03:02:15PM +0530, navin patidar wrote: > On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter > wrote: > > On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: > >> stub_device_reset should set kernel thread pointers to NULL. > >> so that at the time of usbip_host

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter wrote: > On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: >> stub_device_reset should set kernel thread pointers to NULL. >> so that at the time of usbip_host removal stub_shoutdown_connection >> doesn't try to kill kernel threads which

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: > stub_device_reset should set kernel thread pointers to NULL. > so that at the time of usbip_host removal stub_shoutdown_connection > doesn't try to kill kernel threads which are already killed. > If you have the Oops output, that's

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. If you have the Oops output, that's

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 03:02:15PM +0530, navin patidar wrote: On Tue, Sep 18, 2012 at 1:10 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

for usbip_host event_handler() handles following events. defined in usbip_common.h 1. SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) 2. SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) 3. SDEV_EVENT_ERROR_TCP(USBIP_EH_SHUTDOWN |

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Tue, Sep 18, 2012 at 05:14:41PM +0530, navin patidar wrote: for usbip_host event_handler() handles following events. defined in usbip_common.h 1. SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) 2. SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN |

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c |7 --- 1 file changed, 4

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 03:23:23PM +0530, navin patidar wrote: > --- > > This e-mail is for the sole use of the intended recipient(s) and may > contain confidential and

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 03:23:23PM +0530, navin patidar wrote: --- This e-mail is for the sole use of the intended recipient(s) and may contain confidential and

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c |7 --- 1 file

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 04:28:33PM +0200, Sebastian Andrzej Siewior wrote: > On Fri, Sep 14, 2012 at 05:16:38PM +0300, Dan Carpenter wrote: > > I don't think this text is allowed on patches. > > Oh Oh Oh Dan, I think you crossed a line here. You were not one of the > recipient and you reviewed

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

hi, I have sent this patch again with corrections. thank for reviewing the patch. --navin-patidar On 9/14/12, Sebastian Andrzej Siewior wrote: > On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: >> >diff --git a/drivers/staging/usbip/stub_dev.c >> >

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 05:16:38PM +0300, Dan Carpenter wrote: > I don't think this text is allowed on patches. Oh Oh Oh Dan, I think you crossed a line here. You were not one of the recipient and you reviewed and forwarded the email but you should have deleted this email instead. Now legal

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

Hello. On 09/14/2012 04:36 PM, navin patidar wrote: > hi Sergei, > checkpatch.pl didn't complain any thing about patch > coding style. checkpatch.pl only complains about // comments, IIRC. But see Documentation/CodingStyle chapter 8 about multi-line comments. As for

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 06:51:33PM +0530, navin patidar wrote: > stub_device_reset should set kernel thread pointers to NULL. > so that at the time of usbip_host removal stub_shoutdown_connection > doesn't try to kill kernel threads which are already killed. > If you wanted to put a sample Oops

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c |7 --- 1 file changed, 4

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: > >diff --git a/drivers/staging/usbip/stub_dev.c > >b/drivers/staging/usbip/stub_dev.c > >index 92ced35..f584af8 100644 > >--- a/drivers/staging/usbip/stub_dev.c > >+++ b/drivers/staging/usbip/stub_dev.c > >@@ -233,6 +230,13 @@

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

Hello. On 14-09-2012 13:53, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar ---

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar --- drivers/staging/usbip/stub_dev.c | 14 +- 1 file changed,

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c | 14 +- 1

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

Hello. On 14-09-2012 13:53, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in ---

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c index 92ced35..f584af8 100644 --- a/drivers/staging/usbip/stub_dev.c +++ b/drivers/staging/usbip/stub_dev.c @@ -233,6 +230,13 @@ static void

[PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_dev.c |7 --- 1 file

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 06:51:33PM +0530, navin patidar wrote: stub_device_reset should set kernel thread pointers to NULL. so that at the time of usbip_host removal stub_shoutdown_connection doesn't try to kill kernel threads which are already killed. If you wanted to put a sample Oops

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

Hello. On 09/14/2012 04:36 PM, navin patidar wrote: hi Sergei, checkpatch.pl http://checkpatch.pl didn't complain any thing about patch coding style. checkpatch.pl only complains about // comments, IIRC. But see Documentation/CodingStyle chapter 8 about multi-line comments. As for adding

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 05:16:38PM +0300, Dan Carpenter wrote: I don't think this text is allowed on patches. Oh Oh Oh Dan, I think you crossed a line here. You were not one of the recipient and you reviewed and forwarded the email but you should have deleted this email instead. Now legal action

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

hi, I have sent this patch again with corrections. thank for reviewing the patch. --navin-patidar On 9/14/12, Sebastian Andrzej Siewior sebast...@breakpoint.cc wrote: On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: diff --git a/drivers/staging/usbip/stub_dev.c

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

On Fri, Sep 14, 2012 at 04:28:33PM +0200, Sebastian Andrzej Siewior wrote: On Fri, Sep 14, 2012 at 05:16:38PM +0300, Dan Carpenter wrote: I don't think this text is allowed on patches. Oh Oh Oh Dan, I think you crossed a line here. You were not one of the recipient and you reviewed and