Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter 
Nope.

regards,
dan carpenter

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter 
Nope.

regards,
dan carpenter

[PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Surender Polsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surender Polsani 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
Changes for v4:
removed label as suggested by Dan Carpenter
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..f3871a5 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -144,8 +144,8 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 
hw_init_completed = Adapter->hw_init_completed;
 
-   if (!hw_init_completed)
-   goto skip_dm;
+   if (hw_init_completed)
+   {
 
/* ODM */
pmlmepriv = >mlmepriv;
@@ -162,10 +162,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 
Adapter->HalData->odmpriv.bLinked = bLinked;
ODM_DMWatchdog(>HalData->odmpriv);
-skip_dm:
+   }
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

[PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Surender Polsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surender Polsani 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
Changes for v4:
removed label as suggested by Dan Carpenter
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..f3871a5 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -144,8 +144,8 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 
hw_init_completed = Adapter->hw_init_completed;
 
-   if (!hw_init_completed)
-   goto skip_dm;
+   if (hw_init_completed)
+   {
 
/* ODM */
pmlmepriv = >mlmepriv;
@@ -162,10 +162,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 
Adapter->HalData->odmpriv.bLinked = bLinked;
ODM_DMWatchdog(>HalData->odmpriv);
-skip_dm:
+   }
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter 
On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: Surender Polsani 
> ---
> Changes for v2:
> corrected subject line as suggested
> Changes for v3:
> modified from line as suggested by Greg KH
> placed a semicolon in label for fixing build error
> ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
> b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index d04b7fb..428996e 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
>  skip_dm:
>   /*  Check GPIO to determine current RF on/off and Pbc status. */
>   /*  Check Hardware Radio ON/OFF or not */
> - return;
> + ;

Just get rid of the label.

regards,
dan carpenter

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-05-03 Thread Dan Carpenter 
On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: Surender Polsani 
> ---
> Changes for v2:
> corrected subject line as suggested
> Changes for v3:
> modified from line as suggested by Greg KH
> placed a semicolon in label for fixing build error
> ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
> b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index d04b7fb..428996e 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
>  skip_dm:
>   /*  Check GPIO to determine current RF on/off and Pbc status. */
>   /*  Check Hardware Radio ON/OFF or not */
> - return;
> + ;

Just get rid of the label.

regards,
dan carpenter

[PATCH] staging : rtl8188eu : remove void function return

2017-05-02 Thread Surender Polsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surender Polsani 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..428996e 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
+   ;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

[PATCH] staging : rtl8188eu : remove void function return

2017-05-02 Thread Surender Polsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surender Polsani 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..428996e 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
+   ;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-28 Thread Greg KH 
On Fri, Apr 21, 2017 at 09:24:57AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: Surenderp 

Your "From" line does not match this line.

And I need a "full" name here.

thanks,

greg k-h

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-28 Thread Greg KH 
On Fri, Apr 21, 2017 at 09:24:57AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: Surenderp 

Your "From" line does not match this line.

And I need a "full" name here.

thanks,

greg k-h

[PATCH] staging : rtl8188eu : remove void function return

2017-04-20 Thread surenderpolsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surenderp 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..428996e 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
+   ;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

[PATCH] staging : rtl8188eu : remove void function return

2017-04-20 Thread surenderpolsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surenderp 
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..428996e 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
+   ;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-18 Thread Joe Perches 
On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> > 
> > Signed-off-by: surenderpolsani 
> 
> I need a "real" name here, and in the from line please.  Use what you
> use to sign documents.

You'll also need a patch that compiles properly.

void foo(void)
{
goto bar;
bar:
}

doesn't compile with gcc.

This patch removes the required statement after the
label immediately before the function end.

It could be replaced by just a semicolon which is
done a few places in the kernel or just left as-is.

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-18 Thread Joe Perches 
On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> > 
> > Signed-off-by: surenderpolsani 
> 
> I need a "real" name here, and in the from line please.  Use what you
> use to sign documents.

You'll also need a patch that compiles properly.

void foo(void)
{
goto bar;
bar:
}

doesn't compile with gcc.

This patch removes the required statement after the
label immediately before the function end.

It could be replaced by just a semicolon which is
done a few places in the kernel or just left as-is.

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-18 Thread Greg KH 
On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: surenderpolsani 

I need a "real" name here, and in the from line please.  Use what you
use to sign documents.

thanks,

greg k-h

Re: [PATCH] staging : rtl8188eu : remove void function return

2017-04-18 Thread Greg KH 
On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
> 
> Signed-off-by: surenderpolsani 

I need a "real" name here, and in the from line please.  Use what you
use to sign documents.

thanks,

greg k-h

[PATCH] staging : rtl8188eu : remove void function return

2017-04-15 Thread surenderpolsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: surenderpolsani 
---
Changes for v2:
corrected subject line as suggested
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..6db0e19 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

[PATCH] staging : rtl8188eu : remove void function return

2017-04-15 Thread surenderpolsani 
kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: surenderpolsani 
---
Changes for v2:
corrected subject line as suggested
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c 
b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..6db0e19 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
/*  Check GPIO to determine current RF on/off and Pbc status. */
/*  Check Hardware Radio ON/OFF or not */
-   return;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1