drivers/scsi/storvsc_drv.c:1500:13-20: WARNING: kzalloc should be used for 
payload, instead of kmalloc/memset


 Use kzalloc rather than kmalloc followed by memset with 0

 This considers some simple cases that are common and easy to validate
 Note in particular that there are no ...s in the rule, so all of the
 matched code has to be contiguous

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

CC: Cathy Avery <cav...@redhat.com>
Signed-off-by: Fengguang Wu <fengguang...@intel.com>
---

 storvsc_drv.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1497,10 +1497,9 @@ static int storvsc_queuecommand(struct S
 
                        payload_sz = (sg_count * sizeof(u64) +
                                      sizeof(struct vmbus_packet_mpb_array));
-                       payload = kmalloc(payload_sz, GFP_ATOMIC);
+                       payload = kzalloc(payload_sz, GFP_ATOMIC);
                        if (!payload)
                                return SCSI_MLQUEUE_DEVICE_BUSY;
-                       memset(payload, 0, payload_sz);
                }
 
                payload->range.len = length;

Reply via email to