Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
On Fri 2007-03-09 23:34:00, Rafael J. Wysocki wrote: > On Friday, 9 March 2007 23:13, Pavel Machek wrote: > > Hi! > > > > > > > Index: linux-2.6.21-rc3/kernel/power/user.c > > > > > === > > > > > ---

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 23:13, Pavel Machek wrote: > Hi! > > > > > Index: linux-2.6.21-rc3/kernel/power/user.c > > > > === > > > > --- linux-2.6.21-rc3.orig/kernel/power/user.c > > > > +++ linux-2.6.21-rc3/kernel/power/user.c > > > >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! > > > Index: linux-2.6.21-rc3/kernel/power/user.c > > > === > > > --- linux-2.6.21-rc3.orig/kernel/power/user.c > > > +++ linux-2.6.21-rc3/kernel/power/user.c > > > @@ -402,9 +402,10 @@ static int snapshot_ioctl(struct inode * >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! > > ...so, if pm_ops is non-null, power_down does nonboot cpu disabling, > > otherwise we proceed with cpus enabled? > > > > That looks ugly. > > > > Is the warning bogus? Or maybe we should *always* disable nonboot cpus > > in powerdown path? > > Is disable_nonboot_cpus() assuming that

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 22:07, Pavel Machek wrote: > Hi! > > > > > > > Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > > > > === > > > > > > --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c > > > > > > +++

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! > > > > > Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > > > === > > > > > --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c > > > > > +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > > > @@ -61,6 +61,7 @@ static void

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
Hi, On Friday, 9 March 2007 09:54, Pavel Machek wrote: > Hi! > > > > > Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > > === > > > > --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c > > > > +++

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 13:29, Heiko Carstens wrote: > On Wed, Mar 07, 2007 at 09:07:17PM +, Pavel Machek wrote: > > Hi! > > > > > Prevent the WARN_ON() in > > > arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > from triggering by disabling nonboot CPUs before we finally enter the >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Heiko Carstens
On Wed, Mar 07, 2007 at 09:07:17PM +, Pavel Machek wrote: > Hi! > > > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > from triggering by disabling nonboot CPUs before we finally enter the > > platform > > suspend. > > > > Signed-off-by: Rafael J. Wysocki

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! > > > Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > === > > > --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c > > > +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c > > > @@ -61,6 +61,7 @@ static void

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c === --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c @@ -61,6 +61,7 @@ static void power_down(suspend_disk_meth

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Heiko Carstens
On Wed, Mar 07, 2007 at 09:07:17PM +, Pavel Machek wrote: Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED]

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 13:29, Heiko Carstens wrote: On Wed, Mar 07, 2007 at 09:07:17PM +, Pavel Machek wrote: Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
Hi, On Friday, 9 March 2007 09:54, Pavel Machek wrote: Hi! Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c === --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c @@

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c === --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c @@ -61,6 +61,7 @@ static void

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 22:07, Pavel Machek wrote: Hi! Index: linux-2.6.21-rc2-mm2/kernel/power/disk.c === --- linux-2.6.21-rc2-mm2.orig/kernel/power/disk.c +++ linux-2.6.21-rc2-mm2/kernel/power/disk.c

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! ...so, if pm_ops is non-null, power_down does nonboot cpu disabling, otherwise we proceed with cpus enabled? That looks ugly. Is the warning bogus? Or maybe we should *always* disable nonboot cpus in powerdown path? Is disable_nonboot_cpus() assuming that

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
Hi! Index: linux-2.6.21-rc3/kernel/power/user.c === --- linux-2.6.21-rc3.orig/kernel/power/user.c +++ linux-2.6.21-rc3/kernel/power/user.c @@ -402,9 +402,10 @@ static int snapshot_ioctl(struct inode *

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Rafael J. Wysocki
On Friday, 9 March 2007 23:13, Pavel Machek wrote: Hi! Index: linux-2.6.21-rc3/kernel/power/user.c === --- linux-2.6.21-rc3.orig/kernel/power/user.c +++ linux-2.6.21-rc3/kernel/power/user.c @@ -402,9 +402,10 @@

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-09 Thread Pavel Machek
On Fri 2007-03-09 23:34:00, Rafael J. Wysocki wrote: On Friday, 9 March 2007 23:13, Pavel Machek wrote: Hi! Index: linux-2.6.21-rc3/kernel/power/user.c === --- linux-2.6.21-rc3.orig/kernel/power/user.c +++

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 22:07, Pavel Machek wrote: > Hi! > > > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > from triggering by disabling nonboot CPUs before we finally enter the > > platform > > suspend. > > > > Signed-off-by: Rafael J. Wysocki <[EMAIL

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Pavel Machek
Hi! > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > from triggering by disabling nonboot CPUs before we finally enter the platform > suspend. > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > --- > kernel/power/disk.c |1 + > kernel/power/user.c |

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Rafael J. Wysocki
On Friday, 9 March 2007 02:11, Len Brown wrote: > On Wednesday 07 March 2007 18:13, Rafael J. Wysocki wrote: > > On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: > > > On Wed, 7 Mar 2007 23:14:29 +0100 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > > On Wednesday, 7 March

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Len Brown
On Wednesday 07 March 2007 18:13, Rafael J. Wysocki wrote: > On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: > > On Wed, 7 Mar 2007 23:14:29 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: > > > > On Wed, 7 Mar 2007

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Len Brown
On Wednesday 07 March 2007 18:13, Rafael J. Wysocki wrote: On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: On Wed, 7 Mar 2007 23:14:29 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: On Wed, 7 Mar 2007 20:44:11 +0100

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Rafael J. Wysocki
On Friday, 9 March 2007 02:11, Len Brown wrote: On Wednesday 07 March 2007 18:13, Rafael J. Wysocki wrote: On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: On Wed, 7 Mar 2007 23:14:29 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 7 March 2007 22:16, Andrew

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Pavel Machek
Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- kernel/power/disk.c |1 + kernel/power/user.c |2 +- 2

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-08 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 22:07, Pavel Machek wrote: Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] ---

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Thursday, 8 March 2007 01:20, Dave Jones wrote: > On Thu, Mar 08, 2007 at 12:13:05AM +0100, Rafael J. Wysocki wrote: > > > > > Well, the WARN_ON() in > arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > > triggers every time an SMP x86_64 box is suspended to disk using the > platform

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Dave Jones
On Thu, Mar 08, 2007 at 12:13:05AM +0100, Rafael J. Wysocki wrote: > > > Well, the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > triggers every time an SMP x86_64 box is suspended to disk using the > > > platform > > > mode (default), which is quite annoying IMHO and

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: > On Wed, 7 Mar 2007 23:14:29 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: > > > On Wed, 7 Mar 2007 20:44:11 +0100 > > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 23:19, Pavel Machek wrote: > Hi! > > > > > Prevent the WARN_ON() in > > > > arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > > from triggering by disabling nonboot CPUs before we finally enter the > > > > platform > > > > suspend. > > > > > > > >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Andrew Morton
On Wed, 7 Mar 2007 23:14:29 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: > > On Wed, 7 Mar 2007 20:44:11 +0100 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > > >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Pavel Machek
Hi! > > > Prevent the WARN_ON() in > > > arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > > from triggering by disabling nonboot CPUs before we finally enter the > > > platform > > > suspend. > > > > > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > --- > > >

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: > On Wed, 7 Mar 2007 20:44:11 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > > from triggering by

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Andrew Morton
On Wed, 7 Mar 2007 20:44:11 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() > from triggering by disabling nonboot CPUs before we finally enter the platform >

[PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> --- kernel/power/disk.c |1 +

[PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- kernel/power/disk.c |1 +

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Andrew Morton
On Wed, 7 Mar 2007 20:44:11 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend.

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: On Wed, 7 Mar 2007 20:44:11 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Pavel Machek
Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- kernel/power/disk.c |1 +

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Andrew Morton
On Wed, 7 Mar 2007 23:14:29 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: On Wed, 7 Mar 2007 20:44:11 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] Prevent the WARN_ON() in

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 23:49, Andrew Morton wrote: On Wed, 7 Mar 2007 23:14:29 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Wednesday, 7 March 2007 22:16, Andrew Morton wrote: On Wed, 7 Mar 2007 20:44:11 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: From: Rafael

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Wednesday, 7 March 2007 23:19, Pavel Machek wrote: Hi! Prevent the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() from triggering by disabling nonboot CPUs before we finally enter the platform suspend. Signed-off-by: Rafael J. Wysocki [EMAIL

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Dave Jones
On Thu, Mar 08, 2007 at 12:13:05AM +0100, Rafael J. Wysocki wrote: Well, the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() triggers every time an SMP x86_64 box is suspended to disk using the platform mode (default), which is quite annoying IMHO and users think

Re: [PATCH] swsusp: Disable nonboot CPUs before entering platform suspend

2007-03-07 Thread Rafael J. Wysocki
On Thursday, 8 March 2007 01:20, Dave Jones wrote: On Thu, Mar 08, 2007 at 12:13:05AM +0100, Rafael J. Wysocki wrote: Well, the WARN_ON() in arch/x86_64/kernel/acpi/sleep.c:init_low_mapping() triggers every time an SMP x86_64 box is suspended to disk using the platform mode