Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

2020-10-14 Thread Cyril Hrubis
Hi! > > I would like to avoid triggering the "your system may be vunerable" > > messages on fixed kernel, hence the separate test. > > Good point, go ahead with a separate test then. Thanks for the review, pushed. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

2020-09-11 Thread Martin Doucha
Hi, the code looks good, though it might make sense to simply integrate the check into ptrace08. Just 6 extra lines in the existing test should achieve the same coverage. It also seems the bug existed long before the CVE 2018-1000199 fix because the test fails on vulnerable kernels as well.

Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

2020-09-11 Thread Martin Doucha
On 11. 09. 20 17:36, Cyril Hrubis wrote: > I would like to avoid triggering the "your system may be vunerable" > messages on fixed kernel, hence the separate test. Good point, go ahead with a separate test then. -- Martin Doucha mdou...@suse.cz QA Engineer for Software Maintenance SUSE LINUX,

Re: [LTP] [PATCH] syscalls/ptrace10: Add new regression test

2020-09-11 Thread Cyril Hrubis
Hi! > the code looks good, though it might make sense to simply integrate the > check into ptrace08. Just 6 extra lines in the existing test should > achieve the same coverage. I would like to avoid triggering the "your system may be vunerable" messages on fixed kernel, hence the separate test.

[PATCH] syscalls/ptrace10: Add new regression test

2020-09-04 Thread Cyril Hrubis
New regression test for a kernel commit: commit bd14406b78e6daa1ea3c1673bda1ffc9efdeead0 Author: Jiri Olsa Date: Mon Aug 27 11:12:25 2018 +0200 perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set Signed-off-by: Cyril Hrubis CC: Andy Lutomirski CC: Peter Zijlstra