Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
Hello Eric, > Sure, but if we put this flag to zero, nobody will ever use it and > find any bug. I agree. > If we can add the MSG_MORE at the right place, your workload might gain > ~20% exec time, and maybe 30% better efficiency, since you'll divide by > 2 the total number of network segments.

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Eric Dumazet
On Sat, 2014-02-08 at 17:55 +0100, Thomas Glanzmann wrote: > Hello Eric, > > > > Disable auto corking by default > > > We should let auto corking on during 3.14 development cycle so that we > > can fix the bugs, and thing of some optimizations. > > I agree that leaving it enabled helps to find

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
Hello Eric, > > Disable auto corking by default > We should let auto corking on during 3.14 development cycle so that we > can fix the bugs, and thing of some optimizations. I agree that leaving it enabled helps to find bugs, however I'm not happy with the round trip time degradation. > auto

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Eric Dumazet
On Sat, 2014-02-08 at 10:19 +0100, Thomas Glanzmann wrote: > When using auto corking with iSCSI the round trip time at least increases by > factor 25 probably more. Other protocols are very likely also effected. > > Signed-off-by: Thomas Glanzmann > --- > net/ipv4/tcp.c |2 +- > 1 file

[PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
When using auto corking with iSCSI the round trip time at least increases by factor 25 probably more. Other protocols are very likely also effected. Signed-off-by: Thomas Glanzmann --- net/ipv4/tcp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c

[PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
When using auto corking with iSCSI the round trip time at least increases by factor 25 probably more. Other protocols are very likely also effected. Signed-off-by: Thomas Glanzmann tho...@glanzmann.de --- net/ipv4/tcp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Eric Dumazet
On Sat, 2014-02-08 at 10:19 +0100, Thomas Glanzmann wrote: When using auto corking with iSCSI the round trip time at least increases by factor 25 probably more. Other protocols are very likely also effected. Signed-off-by: Thomas Glanzmann tho...@glanzmann.de --- net/ipv4/tcp.c |2 +-

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
Hello Eric, Disable auto corking by default We should let auto corking on during 3.14 development cycle so that we can fix the bugs, and thing of some optimizations. I agree that leaving it enabled helps to find bugs, however I'm not happy with the round trip time degradation. auto cork

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Eric Dumazet
On Sat, 2014-02-08 at 17:55 +0100, Thomas Glanzmann wrote: Hello Eric, Disable auto corking by default We should let auto corking on during 3.14 development cycle so that we can fix the bugs, and thing of some optimizations. I agree that leaving it enabled helps to find bugs,

Re: [PATCH] tcp: disable auto corking by default

2014-02-08 Thread Thomas Glanzmann
Hello Eric, Sure, but if we put this flag to zero, nobody will ever use it and find any bug. I agree. If we can add the MSG_MORE at the right place, your workload might gain ~20% exec time, and maybe 30% better efficiency, since you'll divide by 2 the total number of network segments.