Re: [PATCH] tcp_sendpage(): fix broken page iteration

2007-03-18 Thread Dan Aloni
On Sun, Mar 18, 2007 at 02:49:27PM -0700, David Miller wrote: > From: Dan Aloni <[EMAIL PROTECTED]> > Date: Sun, 18 Mar 2007 14:43:46 +0200 > > > do_tcp_sendpages() should not iterate 'pages' as an array since > > it is not an array of 'struct page *', but a pointer to a single > > entity of 'st

Re: [PATCH] tcp_sendpage(): fix broken page iteration

2007-03-18 Thread David Miller
From: Dan Aloni <[EMAIL PROTECTED]> Date: Sun, 18 Mar 2007 14:43:46 +0200 > do_tcp_sendpages() should not iterate 'pages' as an array since > it is not an array of 'struct page *', but a pointer to a single > entity of 'struct page *' passed on the stack as a parameter to > tcp_send_page() (hen

Re: [PATCH] tcp_sendpage(): fix broken page iteration

2007-03-18 Thread Dan Aloni
On Sun, Mar 18, 2007 at 02:43:46PM +0200, Dan Aloni wrote: > do_tcp_sendpages() should not iterate 'pages' as an array since > it is not an array of 'struct page *', but a pointer to a single > entity of 'struct page *' passed on the stack as a parameter to > tcp_send_page() (hence it would cras

[PATCH] tcp_sendpage(): fix broken page iteration

2007-03-18 Thread Dan Aloni
do_tcp_sendpages() should not iterate 'pages' as an array since it is not an array of 'struct page *', but a pointer to a single entity of 'struct page *' passed on the stack as a parameter to tcp_send_page() (hence it would crash if poffset + psize > PAGE_SIZE, because pages[1] and beyond most