Re: [PATCH] tg3: fix length overflow in VPD firmware parsing

2013-03-27 Thread David Miller
From: Kees Cook Date: Wed, 27 Mar 2013 09:40:50 -0700 > Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 ("tg3: Use VPD fw version > when present") introduced VPD parsing that contained a potential length > overflow. > > Limit the hardware's reported firmware string length (max 255 bytes) to >

[PATCH] tg3: fix length overflow in VPD firmware parsing

2013-03-27 Thread Kees Cook
Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 ("tg3: Use VPD fw version when present") introduced VPD parsing that contained a potential length overflow. Limit the hardware's reported firmware string length (max 255 bytes) to stay inside the driver's firmware string length (32 bytes). On

[PATCH] tg3: fix length overflow in VPD firmware parsing

2013-03-27 Thread Kees Cook
Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 (tg3: Use VPD fw version when present) introduced VPD parsing that contained a potential length overflow. Limit the hardware's reported firmware string length (max 255 bytes) to stay inside the driver's firmware string length (32 bytes). On

Re: [PATCH] tg3: fix length overflow in VPD firmware parsing

2013-03-27 Thread David Miller
From: Kees Cook keesc...@chromium.org Date: Wed, 27 Mar 2013 09:40:50 -0700 Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 (tg3: Use VPD fw version when present) introduced VPD parsing that contained a potential length overflow. Limit the hardware's reported firmware string length (max 255