Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Bart Van Assche
On 05/30/13 01:01, Andrew Morton wrote: On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche wrote: Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Actually "when the jiffies counter has recently wrapped". I assume

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Andrew Morton
On Wed, 29 May 2013 17:13:49 -0700 Joe Perches wrote: > On Wed, 2013-05-29 at 16:38 -0700, Andrew Morton wrote: > > On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > > > > > We could perhaps have a checkpatch rule > > > > which looks for comparisons against jiffes (and any other > > >

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Joe Perches
On Wed, 2013-05-29 at 16:38 -0700, Andrew Morton wrote: > On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > > > We could perhaps have a checkpatch rule > > > which looks for comparisons against jiffes (and any other > > > time-measuring variables we can detect) > > > > other variables

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Joe Perches
On Wed, 2013-05-29 at 16:38 -0700, Andrew Morton wrote: > On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > > > We could perhaps have a checkpatch rule > > > which looks for comparisons against jiffes (and any other > > > time-measuring variables we can detect) > > > > other variables

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Andrew Morton
On Wed, 29 May 2013 16:17:47 -0700 Joe Perches wrote: > > We could perhaps have a checkpatch rule > > which looks for comparisons against jiffes (and any other > > time-measuring variables we can detect) > > other variables like? Grepping for time_after finds a bunch. There's no real pattern

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Joe Perches
On Wed, 2013-05-29 at 16:01 -0700, Andrew Morton wrote: > On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche > wrote: > > > Make sure that the round_jiffies*() functions return a time that is > > in the future when the jiffies counter is about to wrap. > > Actually "when the jiffies counter has

Re: [PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-29 Thread Andrew Morton
On Tue, 21 May 2013 20:43:50 +0200 Bart Van Assche wrote: > Make sure that the round_jiffies*() functions return a time that is > in the future when the jiffies counter is about to wrap. Actually "when the jiffies counter has recently wrapped". I assume this was found by inspection? > @@ -149

[PATCH] timer: Fix jiffies wrap behavior of round_jiffies*()

2013-05-21 Thread Bart Van Assche
Make sure that the round_jiffies*() functions return a time that is in the future when the jiffies counter is about to wrap. Signed-off-by: Bart Van Assche Cc: Thomas Gleixner Cc: Arjan van de Ven Cc: Stephen Rothwell --- kernel/timer.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions