Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-08 Thread Hugh Dickins
On Fri, 5 Feb 2021, Andrew Morton wrote: > On Fri, 5 Feb 2021 17:06:20 -0600 Seth Forshee > wrote: > > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selected there. > > > > The previous patch nicely

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-08 Thread Andrew Morton
On Mon, 8 Feb 2021 07:06:58 -0600 Seth Forshee wrote: > On Sun, Feb 07, 2021 at 05:48:31PM +0300, Kirill A. Shutemov wrote: > > On Fri, Feb 05, 2021 at 05:06:20PM -0600, Seth Forshee wrote: > > > This feature requires ino_t be 64-bits, which is true for every > > > 64-bit architecture but s390,

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-08 Thread Seth Forshee
On Sun, Feb 07, 2021 at 05:48:31PM +0300, Kirill A. Shutemov wrote: > On Fri, Feb 05, 2021 at 05:06:20PM -0600, Seth Forshee wrote: > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selected there. > > Quick

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-07 Thread Kirill A. Shutemov
On Fri, Feb 05, 2021 at 05:06:20PM -0600, Seth Forshee wrote: > This feature requires ino_t be 64-bits, which is true for every > 64-bit architecture but s390, so prevent this option from being > selected there. Quick grep suggests the same for alpha. Am I wrong? -- Kirill A. Shutemov

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-07 Thread Heiko Carstens
On Fri, Feb 05, 2021 at 04:05:51PM -0800, Andrew Morton wrote: > On Fri, 5 Feb 2021 17:06:20 -0600 Seth Forshee > wrote: > > > This feature requires ino_t be 64-bits, which is true for every > > 64-bit architecture but s390, so prevent this option from being > > selected there. > > > > The

[PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-05 Thread Seth Forshee
This feature requires ino_t be 64-bits, which is true for every 64-bit architecture but s390, so prevent this option from being selected there. Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") Cc: # v5.9+ Signed-off-by: Seth Forshee --- fs/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-05 Thread Andrew Morton
On Fri, 5 Feb 2021 17:06:20 -0600 Seth Forshee wrote: > This feature requires ino_t be 64-bits, which is true for every > 64-bit architecture but s390, so prevent this option from being > selected there. > The previous patch nicely described the end-user impact of the bug. This is

Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390

2021-02-05 Thread Chris Down
Andrew Morton writes: Currently there is an assumption in tmpfs that 64-bit architectures also have a 64-bit ino_t. This is not true on s390 which has a 32-bit ino_t. With CONFIG_TMPFS_INODE64=y tmpfs mounts will get 64-bit inode numbers and display "inode64" in the mount options, but passing