[PATCH] tone down pci=routeirq message
Tone down the message about using "pci=routeirq". I do still get
a few reports, but most are now prompted just by the fact that
my email address appears in dmesg in an "error-type" message.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
= arch/i386/pci/acpi.c 1.18 vs edited =
--- 1.18/arch/i386/pci/acpi.c 2004-10-18 22:44:01 -06:00
+++ edited/arch/i386/pci/acpi.c 2005-02-11 15:30:22 -07:00
@@ -37,21 +37,12 @@
* also do it here in case there are still broken drivers that
* don't use pci_enable_device().
*/
- printk(KERN_INFO "** Routing PCI interrupts for all devices
because \"pci=routeirq\"\n");
- printk(KERN_INFO "** was specified. If this was required to
make a driver work,\n");
- printk(KERN_INFO "** please email the output of \"lspci\" to
[EMAIL PROTECTED]");
- printk(KERN_INFO "** so I can fix the driver.\n");
+ printk(KERN_INFO "PCI: Routing PCI interrupts for all devices
because \"pci=routeirq\" specified\n");
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) !=
NULL)
acpi_pci_irq_enable(dev);
- } else {
- printk(KERN_INFO "** PCI interrupts are no longer routed
automatically. If this\n");
- printk(KERN_INFO "** causes a device to stop working, it is
probably because the\n");
- printk(KERN_INFO "** driver failed to call pci_enable_device().
As a temporary\n");
- printk(KERN_INFO "** workaround, the \"pci=routeirq\" argument
restores the old\n");
- printk(KERN_INFO "** behavior. If this argument makes the
device work again,\n");
- printk(KERN_INFO "** please email the output of \"lspci\" to
[EMAIL PROTECTED]");
- printk(KERN_INFO "** so I can fix the driver.\n");
- }
+ } else
+ printk(KERN_INFO "PCI: If a device doesn't work, try
\"pci=routeirq\". If it helps, post a report\n");
+
#ifdef CONFIG_X86_IO_APIC
if (acpi_ioapic)
print_IO_APIC();
= arch/ia64/pci/pci.c 1.67 vs edited =
--- 1.67/arch/ia64/pci/pci.c2005-01-25 14:23:42 -07:00
+++ edited/arch/ia64/pci/pci.c 2005-02-11 15:28:22 -07:00
@@ -160,21 +160,11 @@
* also do it here in case there are still broken drivers that
* don't use pci_enable_device().
*/
- printk(KERN_INFO "** Routing PCI interrupts for all devices
because \"pci=routeirq\"\n");
- printk(KERN_INFO "** was specified. If this was required to
make a driver work,\n");
- printk(KERN_INFO "** please email the output of \"lspci\" to
[EMAIL PROTECTED]");
- printk(KERN_INFO "** so I can fix the driver.\n");
+ printk(KERN_INFO "PCI: Routing interrupts for all devices
because \"pci=routeirq\" specified\n");
for_each_pci_dev(dev)
acpi_pci_irq_enable(dev);
- } else {
- printk(KERN_INFO "** PCI interrupts are no longer routed
automatically. If this\n");
- printk(KERN_INFO "** causes a device to stop working, it is
probably because the\n");
- printk(KERN_INFO "** driver failed to call pci_enable_device().
As a temporary\n");
- printk(KERN_INFO "** workaround, the \"pci=routeirq\" argument
restores the old\n");
- printk(KERN_INFO "** behavior. If this argument makes the
device work again,\n");
- printk(KERN_INFO "** please email the output of \"lspci\" to
[EMAIL PROTECTED]");
- printk(KERN_INFO "** so I can fix the driver.\n");
- }
+ } else
+ printk(KERN_INFO "PCI: If a device doesn't work, try
\"pci=routeirq\". If it helps, post a report\n");
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] tone down pci=routeirq message
Tone down the message about using pci=routeirq. I do still get
a few reports, but most are now prompted just by the fact that
my email address appears in dmesg in an error-type message.
Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED]
= arch/i386/pci/acpi.c 1.18 vs edited =
--- 1.18/arch/i386/pci/acpi.c 2004-10-18 22:44:01 -06:00
+++ edited/arch/i386/pci/acpi.c 2005-02-11 15:30:22 -07:00
@@ -37,21 +37,12 @@
* also do it here in case there are still broken drivers that
* don't use pci_enable_device().
*/
- printk(KERN_INFO ** Routing PCI interrupts for all devices
because \pci=routeirq\\n);
- printk(KERN_INFO ** was specified. If this was required to
make a driver work,\n);
- printk(KERN_INFO ** please email the output of \lspci\ to
[EMAIL PROTECTED]);
- printk(KERN_INFO ** so I can fix the driver.\n);
+ printk(KERN_INFO PCI: Routing PCI interrupts for all devices
because \pci=routeirq\ specified\n);
while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) !=
NULL)
acpi_pci_irq_enable(dev);
- } else {
- printk(KERN_INFO ** PCI interrupts are no longer routed
automatically. If this\n);
- printk(KERN_INFO ** causes a device to stop working, it is
probably because the\n);
- printk(KERN_INFO ** driver failed to call pci_enable_device().
As a temporary\n);
- printk(KERN_INFO ** workaround, the \pci=routeirq\ argument
restores the old\n);
- printk(KERN_INFO ** behavior. If this argument makes the
device work again,\n);
- printk(KERN_INFO ** please email the output of \lspci\ to
[EMAIL PROTECTED]);
- printk(KERN_INFO ** so I can fix the driver.\n);
- }
+ } else
+ printk(KERN_INFO PCI: If a device doesn't work, try
\pci=routeirq\. If it helps, post a report\n);
+
#ifdef CONFIG_X86_IO_APIC
if (acpi_ioapic)
print_IO_APIC();
= arch/ia64/pci/pci.c 1.67 vs edited =
--- 1.67/arch/ia64/pci/pci.c2005-01-25 14:23:42 -07:00
+++ edited/arch/ia64/pci/pci.c 2005-02-11 15:28:22 -07:00
@@ -160,21 +160,11 @@
* also do it here in case there are still broken drivers that
* don't use pci_enable_device().
*/
- printk(KERN_INFO ** Routing PCI interrupts for all devices
because \pci=routeirq\\n);
- printk(KERN_INFO ** was specified. If this was required to
make a driver work,\n);
- printk(KERN_INFO ** please email the output of \lspci\ to
[EMAIL PROTECTED]);
- printk(KERN_INFO ** so I can fix the driver.\n);
+ printk(KERN_INFO PCI: Routing interrupts for all devices
because \pci=routeirq\ specified\n);
for_each_pci_dev(dev)
acpi_pci_irq_enable(dev);
- } else {
- printk(KERN_INFO ** PCI interrupts are no longer routed
automatically. If this\n);
- printk(KERN_INFO ** causes a device to stop working, it is
probably because the\n);
- printk(KERN_INFO ** driver failed to call pci_enable_device().
As a temporary\n);
- printk(KERN_INFO ** workaround, the \pci=routeirq\ argument
restores the old\n);
- printk(KERN_INFO ** behavior. If this argument makes the
device work again,\n);
- printk(KERN_INFO ** please email the output of \lspci\ to
[EMAIL PROTECTED]);
- printk(KERN_INFO ** so I can fix the driver.\n);
- }
+ } else
+ printk(KERN_INFO PCI: If a device doesn't work, try
\pci=routeirq\. If it helps, post a report\n);
return 0;
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
