Re: [PATCH] tpm/tpm_crb: Access locality for only CRB_START method

2017-08-08 Thread Jason Gunthorpe
On Sun, Aug 06, 2017 at 09:54:15PM -0500, Jiandi An wrote: > static int __maybe_unused crb_go_idle(struct device *dev, struct crb_priv > *priv) > { > - if ((priv->flags & CRB_FL_ACPI_START) || > - (priv->flags & CRB_FL_CRB_SMC_START)) > + if (!(priv->flags & CRB_FL_CRB_START))

[PATCH] tpm/tpm_crb: Access locality for only CRB_START method

2017-08-06 Thread Jiandi An
For ARM64, the locality is handled by Trust Zone in FW. The layout does not have crb_regs_head. It is hitting the following line. dev_warn(dev, FW_BUG "Bad ACPI memory layout"); Current code excludes CRB_FL_ACPI_START and when CRB_FL_CRB_SMC_START is added around the same time locality support is