Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

2019-09-02 Thread Jarkko Sakkinen
On Fri, Aug 30, 2019 at 09:09:02AM -0700, Jerry Snitselaar wrote: > On Thu Aug 29 19, Jarkko Sakkinen wrote: > + /* TPM 1.1 */ > > + if (tpm1_getcap(chip, TPM_CAP_VERSION_1_1, , > > + "attempting to determine the 1.1 version", > > + sizeof(cap.version1)))

Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

2019-08-30 Thread Jerry Snitselaar
On Thu Aug 29 19, Jarkko Sakkinen wrote: Replace existing TPM 1.x version structs with new structs that consolidate the common parts into a single struct so that code duplication is no longer needed in caps_show(). Cc: Alexey Klimov Cc: Jerry Snitselaar Signed-off-by: Jarkko Sakkinen ---

Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

2019-08-29 Thread Jerry Snitselaar
On Thu Aug 29 19, Jarkko Sakkinen wrote: Replace existing TPM 1.x version structs with new structs that consolidate the common parts into a single struct so that code duplication is no longer needed in caps_show(). Cc: Alexey Klimov Cc: Jerry Snitselaar Signed-off-by: Jarkko Sakkinen ---

[PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c

2019-08-29 Thread Jarkko Sakkinen
Replace existing TPM 1.x version structs with new structs that consolidate the common parts into a single struct so that code duplication is no longer needed in caps_show(). Cc: Alexey Klimov Cc: Jerry Snitselaar Signed-off-by: Jarkko Sakkinen --- Jerry, Alexey: Plese include this to the next