Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-12-06 Thread Masahiro Yamada
2017-11-17 2:05 GMT+09:00 Joe Perches : > On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote: >> On Wed, 15 Nov 2017 14:55:19 -0800 >> Joe Perches wrote: >> >> > Maybe use the much more common below instead? >> > >> > #define pr_fmt(fmt) KBUILD_MODNAME ":

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-12-06 Thread Masahiro Yamada
2017-11-17 2:05 GMT+09:00 Joe Perches : > On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote: >> On Wed, 15 Nov 2017 14:55:19 -0800 >> Joe Perches wrote: >> >> > Maybe use the much more common below instead? >> > >> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> >> Is there someplace this

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-16 Thread Joe Perches
On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote: > On Wed, 15 Nov 2017 14:55:19 -0800 > Joe Perches wrote: > > > Maybe use the much more common below instead? > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Is there someplace this is documented. My git grep

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-16 Thread Joe Perches
On Wed, 2017-11-15 at 21:55 -0500, Steven Rostedt wrote: > On Wed, 15 Nov 2017 14:55:19 -0800 > Joe Perches wrote: > > > Maybe use the much more common below instead? > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Is there someplace this is documented. My git grep foo isn't finding it

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-16 Thread Jiri Kosina
On Wed, 15 Nov 2017, Steven Rostedt wrote: > On Tue, 14 Nov 2017 22:58:31 +0900 > Masami Hiramatsu wrote: > > > On Mon, 13 Nov 2017 14:02:46 -0800 > > Song Liu wrote: > > > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > >

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-16 Thread Jiri Kosina
On Wed, 15 Nov 2017, Steven Rostedt wrote: > On Tue, 14 Nov 2017 22:58:31 +0900 > Masami Hiramatsu wrote: > > > On Mon, 13 Nov 2017 14:02:46 -0800 > > Song Liu wrote: > > > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > > "trace_kprobe". > > > > Oh, good catch! > >

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Steven Rostedt
On Wed, 15 Nov 2017 14:55:19 -0800 Joe Perches wrote: > Maybe use the much more common below instead? > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Is there someplace this is documented. My git grep foo isn't finding it for me. -- Steve

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Steven Rostedt
On Wed, 15 Nov 2017 14:55:19 -0800 Joe Perches wrote: > Maybe use the much more common below instead? > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Is there someplace this is documented. My git grep foo isn't finding it for me. -- Steve

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Joe Perches
On Wed, 2017-11-15 at 13:14 -0500, Steven Rostedt wrote: > On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu > wrote: > > On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu wrote: > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > >

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Joe Perches
On Wed, 2017-11-15 at 13:14 -0500, Steven Rostedt wrote: > On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu > wrote: > > On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu wrote: > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > > "trace_kprobe". > > Oh, good catch! > >

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Steven Rostedt
On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu wrote: > On Mon, 13 Nov 2017 14:02:46 -0800 > Song Liu wrote: > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > "trace_kprobe". > > Oh, good catch! > > Acked-by: Masami

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-15 Thread Steven Rostedt
On Tue, 14 Nov 2017 22:58:31 +0900 Masami Hiramatsu wrote: > On Mon, 13 Nov 2017 14:02:46 -0800 > Song Liu wrote: > > > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > > "trace_kprobe". > > Oh, good catch! > > Acked-by: Masami Hiramatsu > Thanks. Acked-by: Steven

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-14 Thread Masami Hiramatsu
On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu wrote: > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > "trace_kprobe". Oh, good catch! Acked-by: Masami Hiramatsu Thank you! > > Cc: Masami Hiramatsu > Cc:

Re: [PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-14 Thread Masami Hiramatsu
On Mon, 13 Nov 2017 14:02:46 -0800 Song Liu wrote: > pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of > "trace_kprobe". Oh, good catch! Acked-by: Masami Hiramatsu Thank you! > > Cc: Masami Hiramatsu > Cc: Steven Rostedt > Signed-off-by: Song Liu > --- >

[PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-13 Thread Song Liu
pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of "trace_kprobe". Cc: Masami Hiramatsu Cc: Steven Rostedt Signed-off-by: Song Liu --- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] tracing/probe: fix typo in pr_fmt in trace_uprobe.c

2017-11-13 Thread Song Liu
pr_fmt in trace_uprobe.c should say "trace_uprobe" instead of "trace_kprobe". Cc: Masami Hiramatsu Cc: Steven Rostedt Signed-off-by: Song Liu --- kernel/trace/trace_uprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c