Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Steven Rostedt
On Fri, 9 Dec 2016 09:05:51 +0100 Henrik Austad wrote: > Ah, perhaps I jumped the gun here. I don't think Linus has picked this one > up yet, Steven sent out the patch yesterday. Correct, and since it's rc8 and I've just finished testing this, I think I'll just wait till

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Steven Rostedt
On Fri, 9 Dec 2016 09:05:51 +0100 Henrik Austad wrote: > Ah, perhaps I jumped the gun here. I don't think Linus has picked this one > up yet, Steven sent out the patch yesterday. Correct, and since it's rc8 and I've just finished testing this, I think I'll just wait till the merge window to

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Greg KH
On Fri, Dec 09, 2016 at 09:05:51AM +0100, Henrik Austad wrote: > On Fri, Dec 09, 2016 at 08:22:05AM +0100, Greg KH wrote: > > On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > > > Instead of using get_user_pages_fast() and kmap_atomic() when writing > > > to the trace_marker file,

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Greg KH
On Fri, Dec 09, 2016 at 09:05:51AM +0100, Henrik Austad wrote: > On Fri, Dec 09, 2016 at 08:22:05AM +0100, Greg KH wrote: > > On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > > > Instead of using get_user_pages_fast() and kmap_atomic() when writing > > > to the trace_marker file,

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Henrik Austad
On Fri, Dec 09, 2016 at 08:22:05AM +0100, Greg KH wrote: > On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > > Instead of using get_user_pages_fast() and kmap_atomic() when writing > > to the trace_marker file, just allocate enough space on the ring buffer > > directly, and write

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-09 Thread Henrik Austad
On Fri, Dec 09, 2016 at 08:22:05AM +0100, Greg KH wrote: > On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > > Instead of using get_user_pages_fast() and kmap_atomic() when writing > > to the trace_marker file, just allocate enough space on the ring buffer > > directly, and write

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-08 Thread Greg KH
On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > Instead of using get_user_pages_fast() and kmap_atomic() when writing > to the trace_marker file, just allocate enough space on the ring buffer > directly, and write into it via copy_from_user(). > > Writing into the trace_marker

Re: [PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-08 Thread Greg KH
On Fri, Dec 09, 2016 at 07:34:04AM +0100, Henrik Austad wrote: > Instead of using get_user_pages_fast() and kmap_atomic() when writing > to the trace_marker file, just allocate enough space on the ring buffer > directly, and write into it via copy_from_user(). > > Writing into the trace_marker

[PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-08 Thread Henrik Austad
Instead of using get_user_pages_fast() and kmap_atomic() when writing to the trace_marker file, just allocate enough space on the ring buffer directly, and write into it via copy_from_user(). Writing into the trace_marker file use to allocate a temporary buffer to perform the copy_from_user(), as

[PATCH] tracing: (backport) Replace kmap with copy_from_user() in trace_marker

2016-12-08 Thread Henrik Austad
Instead of using get_user_pages_fast() and kmap_atomic() when writing to the trace_marker file, just allocate enough space on the ring buffer directly, and write into it via copy_from_user(). Writing into the trace_marker file use to allocate a temporary buffer to perform the copy_from_user(), as