Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-20 Thread divya . indi
On 05/20/2019 08:23 AM, Steven Rostedt wrote: On Wed, 15 May 2019 20:24:43 -0700 Steven Rostedt wrote: It seems your's already in Steve's ftrace/core branch, so I think you can make additional patch to fix it. Steve, is that OK? Yes. In fact I already sent a pull request to Linus.

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-20 Thread Steven Rostedt
On Wed, 15 May 2019 20:24:43 -0700 Steven Rostedt wrote: > > >It seems your's already in Steve's ftrace/core branch, so I think you > >can make > >additional patch to fix it. Steve, is that OK? > > > > Yes. In fact I already sent a pull request to Linus. Please send a patch on > top of my

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-15 Thread Steven Rostedt
On May 15, 2019 8:05:29 PM PDT, Masami Hiramatsu wrote: > >> >> diff --git a/kernel/trace/trace_events.c >b/kernel/trace/trace_events.c >> >> index 5b3b0c3..81c038e 100644 >> >> --- a/kernel/trace/trace_events.c >> >> +++ b/kernel/trace/trace_events.c >> >> @@ -832,6 +832,7 @@ static int

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-15 Thread Masami Hiramatsu
Hi, On Wed, 15 May 2019 18:51:23 -0700 Divya Indi wrote: > Hi Masami, > > Thanks for pointing it out. > > Yes, it should not be static. > > On 5/15/19 5:09 PM, Masami Hiramatsu wrote: > > HI Divya, > > > > On Wed, 20 Mar 2019 11:28:51 -0700 > > Divya Indi wrote: > > > >> Ftrace provides the

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-15 Thread Divya Indi
Hi Masami, Thanks for pointing it out. Yes, it should not be static. On 5/15/19 5:09 PM, Masami Hiramatsu wrote: HI Divya, On Wed, 20 Mar 2019 11:28:51 -0700 Divya Indi wrote: Ftrace provides the feature “instances” that provides the capability to create multiple Ftrace ring buffers.

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-05-15 Thread Masami Hiramatsu
HI Divya, On Wed, 20 Mar 2019 11:28:51 -0700 Divya Indi wrote: > Ftrace provides the feature “instances” that provides the capability to > create multiple Ftrace ring buffers. However, currently these buffers > are created/accessed via userspace only. The kernel APIs providing these > features

Re: [PATCH] tracing: Kernel access to Ftrace instances

2019-03-27 Thread Steven Rostedt
On Wed, 20 Mar 2019 11:28:51 -0700 Divya Indi wrote: > Ftrace provides the feature “instances” that provides the capability to > create multiple Ftrace ring buffers. However, currently these buffers > are created/accessed via userspace only. The kernel APIs providing these > features are not

[PATCH] tracing: Kernel access to Ftrace instances

2019-03-20 Thread Divya Indi
Ftrace provides the feature “instances” that provides the capability to create multiple Ftrace ring buffers. However, currently these buffers are created/accessed via userspace only. The kernel APIs providing these features are not exported, hence cannot be used by other kernel components. This

Re: [PATCH] tracing: Kernel access to ftrace instances

2019-03-20 Thread divya . indi
Sure, thanks for taking the time to review. There are a few issues with the patch styling and some minor modifications. I will shortly send the v2 for the same. Regards, Divya On 03/19/2019 01:16 PM, Steven Rostedt wrote: On Fri, 15 Mar 2019 16:35:25 -0700 Divya Indi wrote: Ftrace

Re: [PATCH] tracing: Kernel access to ftrace instances

2019-03-19 Thread Steven Rostedt
On Fri, 15 Mar 2019 16:35:25 -0700 Divya Indi wrote: > Ftrace provides the feature “instances” that provides the capability to > create multiple Ftrace ring buffers. However, currently these buffers > are created/accessed via userspace only. The kernel APIs providing these > features are not

[PATCH] tracing: Kernel access to ftrace instances

2019-03-15 Thread Divya Indi
Ftrace provides the feature “instances” that provides the capability to create multiple Ftrace ring buffers. However, currently these buffers are created/accessed via userspace only. The kernel APIs providing these features are not exported, hence cannot be used by other kernel components. This