Re: [PATCH] treewide: remove duplicate includes

2017-12-04 Thread Eduardo Valentin 
Hello,

On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:


> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index d04ec3b..e09f035 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -30,7 +30,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  
>  #include "thermal_core.h"
>  

No issues with this but,

Please send a separate patch to linux...@vger.kernel.org and copy 
edube...@gmail.com

thanks,

-- 
All the best,
Eduardo Valentin

Re: [PATCH] treewide: remove duplicate includes

2017-12-04 Thread Eduardo Valentin 
Hello,

On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:


> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index d04ec3b..e09f035 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -30,7 +30,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  
>  #include "thermal_core.h"
>  

No issues with this but,

Please send a separate patch to linux...@vger.kernel.org and copy 
edube...@gmail.com

thanks,

-- 
All the best,
Eduardo Valentin

Re: [PATCH] treewide: remove duplicate includes

2017-12-04 Thread Darrick J. Wong 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes
> 
> Signed-off-by: Pravin Shedge 



> diff --git a/fs/xfs/scrub/scrub.c b/fs/xfs/scrub/scrub.c
> index 9c42c4e..ab3aef2 100644
> --- a/fs/xfs/scrub/scrub.c
> +++ b/fs/xfs/scrub/scrub.c

These look reasonable, but please send me (and linux-xfs) the three
xfs changes separately so that I can add them to the xfs tree.

(Also, thank you for cc'ing the xfs list for this treewide change...)

--D

Re: [PATCH] treewide: remove duplicate includes

2017-12-04 Thread Darrick J. Wong 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes
> 
> Signed-off-by: Pravin Shedge 



> diff --git a/fs/xfs/scrub/scrub.c b/fs/xfs/scrub/scrub.c
> index 9c42c4e..ab3aef2 100644
> --- a/fs/xfs/scrub/scrub.c
> +++ b/fs/xfs/scrub/scrub.c

These look reasonable, but please send me (and linux-xfs) the three
xfs changes separately so that I can add them to the xfs tree.

(Also, thank you for cc'ing the xfs list for this treewide change...)

--D

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Greg KH 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes
> 
> Signed-off-by: Pravin Shedge 

Please break this up per-subsystem, like any other cleanup patch, and
send it out that way.  As it is, no one can take such a patch.

thanks,

greg k-h

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Greg KH 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes
> 
> Signed-off-by: Pravin Shedge 

Please break this up per-subsystem, like any other cleanup patch, and
send it out that way.  As it is, no one can take such a patch.

thanks,

greg k-h

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Joe Perches 
On Mon, 2017-12-04 at 03:19 +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.

Can you list the duplicates that were not removed as well please?

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Joe Perches 
On Mon, 2017-12-04 at 03:19 +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.

Can you list the duplicates that were not removed as well please?

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Luis R. Rodriguez 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes

Can you get 0day to test it?

  Luis

Re: [PATCH] treewide: remove duplicate includes

2017-12-03 Thread Luis R. Rodriguez 
On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Unit Testing:
> 
> - build successful
> - LTP testsuite passes.
> - checkpatch.pl passes

Can you get 0day to test it?

  Luis

[PATCH] treewide: remove duplicate includes

2017-12-03 Thread Pravin Shedge 
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.

Unit Testing:

- build successful
- LTP testsuite passes.
- checkpatch.pl passes

Signed-off-by: Pravin Shedge 
---
 arch/arm/crypto/aes-ce-glue.c   | 1 -
 arch/arm/mach-sa1100/hackkit.c  | 1 -
 arch/arm/mm/mmu.c   | 2 --
 arch/arm/xen/mm.c   | 1 -
 arch/arm64/kernel/armv8_deprecated.c| 1 -
 arch/arm64/kernel/fpsimd.c  | 1 -
 arch/blackfin/kernel/irqchip.c  | 1 -
 arch/blackfin/mach-common/ints-priority.c   | 1 -
 arch/mips/mm/init.c | 2 --
 arch/nios2/mm/fault.c   | 1 -
 arch/parisc/kernel/unwind.c | 1 -
 arch/parisc/lib/delay.c | 2 --
 arch/powerpc/kernel/time.c  | 2 --
 arch/powerpc/lib/code-patching.c| 1 -
 arch/powerpc/mm/numa.c  | 1 -
 arch/powerpc/platforms/powernv/npu-dma.c| 1 -
 arch/powerpc/platforms/powernv/opal.c   | 1 -
 arch/s390/kernel/kprobes.c  | 1 -
 arch/sh/boards/mach-dreamcast/irq.c | 1 -
 arch/sparc/kernel/uprobes.c | 1 -
 arch/tile/kernel/single_step.c  | 1 -
 arch/tile/kernel/unaligned.c| 1 -
 arch/x86/kernel/itmt.c  | 1 -
 arch/x86/kernel/process.c   | 1 -
 arch/x86/kernel/setup.c | 1 -
 arch/x86/kernel/smpboot.c   | 1 -
 arch/x86/platform/efi/efi_64.c  | 1 -
 arch/x86/xen/spinlock.c | 2 --
 drivers/bus/qcom-ebi2.c | 1 -
 drivers/crypto/bcm/cipher.c | 1 -
 drivers/crypto/cavium/nitrox/nitrox_reqmgr.c| 1 -
 drivers/crypto/ccp/ccp-crypto-aes-galois.c  | 1 -
 drivers/gpio/gpio-brcmstb.c | 1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c   | 1 -
 drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c   | 1 -
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c   | 1 -
 drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c| 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c   | 3 ---
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 1 -
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c   | 1 -
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 -
 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c| 1 -
 drivers/gpu/drm/bridge/panel.c  | 1 -
 drivers/gpu/drm/drm_drv.c   | 1 -
 drivers/gpu/drm/i915/intel_dsi_vbt.c| 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c  | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c   | 1 -
 drivers/hwtracing/coresight/coresight-etb10.c   | 1 -
 drivers/iio/gyro/bmg160_core.c  | 1 -
 drivers/infiniband/core/mad.c   | 1 -
 drivers/infiniband/core/netlink.c   | 2 --
 drivers/infiniband/hw/mlx5/main.c   | 4 +---
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c| 1 -
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c| 1 -
 drivers/input/rmi4/rmi_f34.c| 1 -
 drivers/media/platform/pxa_camera.c | 1 -
 drivers/media/platform/ti-vpe/cal.c | 3 ---
 drivers/media/v4l2-core/v4l2-mc.c   | 2 --
 drivers/mfd/intel_soc_pmic_core.c   | 1 -
 drivers/mfd/max77843.c  | 1 -
 drivers/misc/genwqe/card_base.c | 1 -
 drivers/misc/genwqe/card_ddcb.c | 1 -
 drivers/misc/genwqe/card_utils.c| 2 --
 drivers/mmc/host/android-goldfish.c | 2 --
 drivers/net/dsa/bcm_sf2.c   | 1 -
 drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c   | 3 +--
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 -
 drivers/net/ethernet/freescale/gianfar.c| 2 --
 drivers/net/ethernet/qlogic/qed/qed_cxt.c   | 1 -
 drivers/net/usb/lan78xx.c   | 1

[PATCH] treewide: remove duplicate includes

2017-12-03 Thread Pravin Shedge 
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.

Unit Testing:

- build successful
- LTP testsuite passes.
- checkpatch.pl passes

Signed-off-by: Pravin Shedge 
---
 arch/arm/crypto/aes-ce-glue.c   | 1 -
 arch/arm/mach-sa1100/hackkit.c  | 1 -
 arch/arm/mm/mmu.c   | 2 --
 arch/arm/xen/mm.c   | 1 -
 arch/arm64/kernel/armv8_deprecated.c| 1 -
 arch/arm64/kernel/fpsimd.c  | 1 -
 arch/blackfin/kernel/irqchip.c  | 1 -
 arch/blackfin/mach-common/ints-priority.c   | 1 -
 arch/mips/mm/init.c | 2 --
 arch/nios2/mm/fault.c   | 1 -
 arch/parisc/kernel/unwind.c | 1 -
 arch/parisc/lib/delay.c | 2 --
 arch/powerpc/kernel/time.c  | 2 --
 arch/powerpc/lib/code-patching.c| 1 -
 arch/powerpc/mm/numa.c  | 1 -
 arch/powerpc/platforms/powernv/npu-dma.c| 1 -
 arch/powerpc/platforms/powernv/opal.c   | 1 -
 arch/s390/kernel/kprobes.c  | 1 -
 arch/sh/boards/mach-dreamcast/irq.c | 1 -
 arch/sparc/kernel/uprobes.c | 1 -
 arch/tile/kernel/single_step.c  | 1 -
 arch/tile/kernel/unaligned.c| 1 -
 arch/x86/kernel/itmt.c  | 1 -
 arch/x86/kernel/process.c   | 1 -
 arch/x86/kernel/setup.c | 1 -
 arch/x86/kernel/smpboot.c   | 1 -
 arch/x86/platform/efi/efi_64.c  | 1 -
 arch/x86/xen/spinlock.c | 2 --
 drivers/bus/qcom-ebi2.c | 1 -
 drivers/crypto/bcm/cipher.c | 1 -
 drivers/crypto/cavium/nitrox/nitrox_reqmgr.c| 1 -
 drivers/crypto/ccp/ccp-crypto-aes-galois.c  | 1 -
 drivers/gpio/gpio-brcmstb.c | 1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c   | 1 -
 drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c   | 1 -
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c   | 1 -
 drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_vi.c| 1 -
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c   | 3 ---
 drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c   | 1 -
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c   | 1 -
 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 -
 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c| 1 -
 drivers/gpu/drm/bridge/panel.c  | 1 -
 drivers/gpu/drm/drm_drv.c   | 1 -
 drivers/gpu/drm/i915/intel_dsi_vbt.c| 1 -
 drivers/gpu/drm/nouveau/nvkm/subdev/bus/nv04.c  | 2 --
 drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c   | 1 -
 drivers/hwtracing/coresight/coresight-etb10.c   | 1 -
 drivers/iio/gyro/bmg160_core.c  | 1 -
 drivers/infiniband/core/mad.c   | 1 -
 drivers/infiniband/core/netlink.c   | 2 --
 drivers/infiniband/hw/mlx5/main.c   | 4 +---
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c| 1 -
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c| 1 -
 drivers/input/rmi4/rmi_f34.c| 1 -
 drivers/media/platform/pxa_camera.c | 1 -
 drivers/media/platform/ti-vpe/cal.c | 3 ---
 drivers/media/v4l2-core/v4l2-mc.c   | 2 --
 drivers/mfd/intel_soc_pmic_core.c   | 1 -
 drivers/mfd/max77843.c  | 1 -
 drivers/misc/genwqe/card_base.c | 1 -
 drivers/misc/genwqe/card_ddcb.c | 1 -
 drivers/misc/genwqe/card_utils.c| 2 --
 drivers/mmc/host/android-goldfish.c | 2 --
 drivers/net/dsa/bcm_sf2.c   | 1 -
 drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c   | 3 +--
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 -
 drivers/net/ethernet/freescale/gianfar.c| 2 --
 drivers/net/ethernet/qlogic/qed/qed_cxt.c   | 1 -
 drivers/net/usb/lan78xx.c   | 1 -