Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Hi, Greg This patch is dropped, I have created another patch based on Jiri' patch. On 2015/12/15 02:55, Greg Kroah-Hartman wrote: On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote: From: xinhui If gsm driver fails to activate one mux, and this mux is not stored in gsm_mux[],

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote: > From: xinhui > > If gsm driver fails to activate one mux, and this mux is not stored in > gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this > is a legal case. So just do a simple check instead of WARN_ON. > > There

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Hi, Greg This patch is dropped, I have created another patch based on Jiri' patch. On 2015/12/15 02:55, Greg Kroah-Hartman wrote: On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote: From: xinhui If gsm driver fails to activate one mux, and this mux is

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote: > From: xinhui > > If gsm driver fails to activate one mux, and this mux is not stored in > gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this > is a legal case. So just do a simple check

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Hi, Jiri I made this patch based on your idea. Any modification is welcome. :) PS. "xinhui" or "xinhui.pan"@linux.vnet.ibm.com are same mail account, both of them are alias. thanks xinhui On 2015/11/25 19:18, xinhui wrote: From: xinhui If gsm driver fails to activate one mux, and

[PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

From: xinhui If gsm driver fails to activate one mux, and this mux is not stored in gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this is a legal case. So just do a simple check instead of WARN_ON. There is one filed gsm->num to store its index of gsm_mux[]. So use gsm->num

[PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

From: xinhui If gsm driver fails to activate one mux, and this mux is not stored in gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this is a legal case. So just do a simple check instead of WARN_ON. There is one filed gsm->num to store its index of

Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement

Hi, Jiri I made this patch based on your idea. Any modification is welcome. :) PS. "xinhui" or "xinhui.pan"@linux.vnet.ibm.com are same mail account, both of them are alias. thanks xinhui On 2015/11/25 19:18, xinhui wrote: From: xinhui If gsm driver fails