Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Andrzej Hajda
On 02/11/2016 04:32 PM, Guenter Roeck wrote: > On Thu, Feb 11, 2016 at 07:45:11AM +0100, Andrzej Hajda wrote: >> On 02/11/2016 04:38 AM, Guenter Roeck wrote: >>> On 02/10/2016 07:21 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > On 02/09/2016 07:26

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Guenter Roeck
On Thu, Feb 11, 2016 at 07:45:11AM +0100, Andrzej Hajda wrote: > On 02/11/2016 04:38 AM, Guenter Roeck wrote: > > On 02/10/2016 07:21 AM, Arnd Bergmann wrote: > >> On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > >>> On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > On Tuesday 09

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Guenter Roeck
On Thu, Feb 11, 2016 at 10:46:50AM +, Russell King - ARM Linux wrote: > On Tue, Feb 09, 2016 at 06:37:46PM -0800, Guenter Roeck wrote: > > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > > >On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > > >>IS_ERR_VALUE() assumes that its parameter

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Russell King - ARM Linux
On Tue, Feb 09, 2016 at 06:37:46PM -0800, Guenter Roeck wrote: > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > >On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > >>IS_ERR_VALUE() assumes that its parameter is an unsigned long. > >>It can not be used to check if an unsigned int reflects

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Andrzej Hajda
On 02/11/2016 04:32 PM, Guenter Roeck wrote: > On Thu, Feb 11, 2016 at 07:45:11AM +0100, Andrzej Hajda wrote: >> On 02/11/2016 04:38 AM, Guenter Roeck wrote: >>> On 02/10/2016 07:21 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > On 02/09/2016 07:26

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Guenter Roeck
On Thu, Feb 11, 2016 at 10:46:50AM +, Russell King - ARM Linux wrote: > On Tue, Feb 09, 2016 at 06:37:46PM -0800, Guenter Roeck wrote: > > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > > >On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > > >>IS_ERR_VALUE() assumes that its parameter

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Russell King - ARM Linux
On Tue, Feb 09, 2016 at 06:37:46PM -0800, Guenter Roeck wrote: > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > >On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > >>IS_ERR_VALUE() assumes that its parameter is an unsigned long. > >>It can not be used to check if an unsigned int reflects

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-11 Thread Guenter Roeck
On Thu, Feb 11, 2016 at 07:45:11AM +0100, Andrzej Hajda wrote: > On 02/11/2016 04:38 AM, Guenter Roeck wrote: > > On 02/10/2016 07:21 AM, Arnd Bergmann wrote: > >> On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > >>> On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > On Tuesday 09

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Baruch Siach
Hi Guenter, On Tue, Feb 09, 2016 at 07:08:59AM -0800, Guenter Roeck wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an unsigned int reflects an error. > Doing so can result in the following build warning. > >

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Andrzej Hajda
On 02/11/2016 04:38 AM, Guenter Roeck wrote: > On 02/10/2016 07:21 AM, Arnd Bergmann wrote: >> On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: >>> On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > IS_ERR_VALUE() assumes that

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Guenter Roeck
On 02/10/2016 07:21 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Arnd Bergmann
On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > > On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > >> IS_ERR_VALUE() assumes that its parameter is an unsigned long. > >> It can not be used to check if an unsigned int reflects an

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Arnd Bergmann
On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: > On 02/09/2016 07:26 AM, Arnd Bergmann wrote: > > On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > >> IS_ERR_VALUE() assumes that its parameter is an unsigned long. > >> It can not be used to check if an unsigned int reflects an

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Andrzej Hajda
On 02/11/2016 04:38 AM, Guenter Roeck wrote: > On 02/10/2016 07:21 AM, Arnd Bergmann wrote: >> On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: >>> On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > IS_ERR_VALUE() assumes that

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Baruch Siach
Hi Guenter, On Tue, Feb 09, 2016 at 07:08:59AM -0800, Guenter Roeck wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an unsigned int reflects an error. > Doing so can result in the following build warning. > >

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-10 Thread Guenter Roeck
On 02/10/2016 07:21 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 18:37:46 Guenter Roeck wrote: On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Guenter Roeck
On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to check if an unsigned int reflects an error. Doing so can result in the following build warning.

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Arnd Bergmann
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an unsigned int reflects an error. > Doing so can result in the following build warning. > > drivers/tty/serial/digicolor-usart.c: In

[PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Guenter Roeck
IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to check if an unsigned int reflects an error. Doing so can result in the following build warning. drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’: include/linux/err.h:21:38: warning:

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Arnd Bergmann
On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an unsigned int reflects an error. > Doing so can result in the following build warning. > > drivers/tty/serial/digicolor-usart.c: In

[PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Guenter Roeck
IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to check if an unsigned int reflects an error. Doing so can result in the following build warning. drivers/tty/serial/digicolor-usart.c: In function ‘digicolor_uart_probe’: include/linux/err.h:21:38: warning:

Re: [PATCH] tty/serial: digicolor: Fix bad usage of IS_ERR_VALUE

2016-02-09 Thread Guenter Roeck
On 02/09/2016 07:26 AM, Arnd Bergmann wrote: On Tuesday 09 February 2016 07:08:59 Guenter Roeck wrote: IS_ERR_VALUE() assumes that its parameter is an unsigned long. It can not be used to check if an unsigned int reflects an error. Doing so can result in the following build warning.