Re: [PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Michael Neuling
Al, On Fri, 2017-04-07 at 05:12 +0100, Al Viro wrote: > On Fri, Apr 07, 2017 at 01:50:53PM +1000, Michael Neuling wrote: > > > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > > index bdf0e6e899..a2a9832a42 100644 > > --- a/drivers/tty/n_tty.c > > +++ b/drivers/tty/n_tty.c > > @@

Re: [PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Michael Neuling
Al, On Fri, 2017-04-07 at 05:12 +0100, Al Viro wrote: > On Fri, Apr 07, 2017 at 01:50:53PM +1000, Michael Neuling wrote: > > > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > > index bdf0e6e899..a2a9832a42 100644 > > --- a/drivers/tty/n_tty.c > > +++ b/drivers/tty/n_tty.c > > @@

Re: [PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Al Viro
On Fri, Apr 07, 2017 at 01:50:53PM +1000, Michael Neuling wrote: > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > index bdf0e6e899..a2a9832a42 100644 > --- a/drivers/tty/n_tty.c > +++ b/drivers/tty/n_tty.c > @@ -1668,11 +1668,17 @@ static int > n_tty_receive_buf_common(struct

Re: [PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Al Viro
On Fri, Apr 07, 2017 at 01:50:53PM +1000, Michael Neuling wrote: > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > index bdf0e6e899..a2a9832a42 100644 > --- a/drivers/tty/n_tty.c > +++ b/drivers/tty/n_tty.c > @@ -1668,11 +1668,17 @@ static int > n_tty_receive_buf_common(struct

[PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Michael Neuling
When reiniting a tty we can end up with: [ 417.514499] Unable to handle kernel paging request for data at address 0x2260 [ 417.515361] Faulting instruction address: 0xc06fad80 cpu 0x15: Vector: 300 (Data Access) at [c0799411f890] pc: c06fad80:

[PATCH] tty: Fix crash with flush_to_ldisc()

2017-04-06 Thread Michael Neuling
When reiniting a tty we can end up with: [ 417.514499] Unable to handle kernel paging request for data at address 0x2260 [ 417.515361] Faulting instruction address: 0xc06fad80 cpu 0x15: Vector: 300 (Data Access) at [c0799411f890] pc: c06fad80: