Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-28 Thread Stephen Boyd
Quoting Ryan Case (2018-11-27 18:37:15) > On Tue, Nov 27, 2018 at 6:04 PM Stephen Boyd wrote: > > > > Quoting Ryan Case (2018-11-27 17:24:44) > > > > > I hope underflow is impossible as well. However, if the hardware did > > > wind up in a strange state I wanted to err on the side of not throwing

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Ryan Case
On Tue, Nov 27, 2018 at 6:04 PM Stephen Boyd wrote: > > Quoting Ryan Case (2018-11-27 17:24:44) > > On Tue, Nov 27, 2018 at 4:20 PM Stephen Boyd wrote: > > > > > > Quoting Ryan Case (2018-11-26 18:25:36) > > > > Transfers were being divided into device FIFO sized (64 byte max) > > > > operations

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Stephen Boyd
Quoting Ryan Case (2018-11-27 17:24:44) > On Tue, Nov 27, 2018 at 4:20 PM Stephen Boyd wrote: > > > > Quoting Ryan Case (2018-11-26 18:25:36) > > > Transfers were being divided into device FIFO sized (64 byte max) > > > operations which would poll for completion within a spin_lock_irqsave / > > >

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Ryan Case
On Tue, Nov 27, 2018 at 4:20 PM Stephen Boyd wrote: > > Quoting Ryan Case (2018-11-26 18:25:36) > > Transfers were being divided into device FIFO sized (64 byte max) > > operations which would poll for completion within a spin_lock_irqsave / > > spin_unlock_irqrestore block. This both made things

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Stephen Boyd
Quoting Ryan Case (2018-11-26 18:25:36) > Transfers were being divided into device FIFO sized (64 byte max) > operations which would poll for completion within a spin_lock_irqsave / > spin_unlock_irqrestore block. This both made things slow by waiting for > the FIFO to completely drain before addin

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Julia Lawall
] tty: serial: qcom_geni_serial: Fix softlock CC: kbuild-...@01.org In-Reply-To: <20181127022536.104663-1-ryandc...@chromium.org> References: <20181127022536.104663-1-ryandc...@chromium.org> TO: Ryan Case CC: Greg Kroah-Hartman , Jiri Slaby , Evan Green , Doug Anderson ,

[PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-26 Thread Ryan Case
Transfers were being divided into device FIFO sized (64 byte max) operations which would poll for completion within a spin_lock_irqsave / spin_unlock_irqrestore block. This both made things slow by waiting for the FIFO to completely drain before adding further data and would also result in softlock