printk replaced with corresponding pr_err, dev_alert, dev_notice and pr_info.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee
---
In the first patch i sent Greg suggested to use dev_err instead of pr_err , but
as later Jiri pointed out in
printk replaced with corresponding pr_err, dev_alert, dev_notice and pr_info.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
In the first patch i sent Greg suggested to use dev_err instead of pr_err , but
as later
>
> Hi, that will not work either, as there is put_device(tty_dev) before
> you use tty_dev.
>
> --
> js
> suse labs
>
Hi,
i missed that. I put my test message to test tty_dev immediately after
tty_dev was initialized and so never got the error when the port was
suspended.
Will change it to pr_err
On 08/05/2014, 02:35 PM, Sudip Mukherjee wrote:
> printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
> pr_info has been used instead of dev_info as there is a check for port->dev
> being NULL or not.
> fixed two broken user-visible strings used by the corresponding
On 08/05/2014, 02:35 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
pr_info has been used instead of dev_info as there is a check for port-dev
being NULL or not.
fixed two broken user-visible strings used by the corresponding printk
Hi, that will not work either, as there is put_device(tty_dev) before
you use tty_dev.
--
js
suse labs
Hi,
i missed that. I put my test message to test tty_dev immediately after
tty_dev was initialized and so never got the error when the port was
suspended.
Will change it to pr_err and
printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
pr_info has been used instead of dev_info as there is a check for port->dev
being NULL or not.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee
---
For my
printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
pr_info has been used instead of dev_info as there is a check for port-dev
being NULL or not.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee
On Wed, Jul 30, 2014 at 8:22 PM, Sudip Mukherjee
wrote:
> On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby wrote:
>> On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
>>> printk replaced with corresponding dev_*
>>> fixed two broken user-visible strings used by the corresponding printk
>>>
>>>
>>>
On Wed, Jul 30, 2014 at 8:22 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby jsl...@suse.cz wrote:
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the
On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby wrote:
> On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
>> printk replaced with corresponding dev_*
>> fixed two broken user-visible strings used by the corresponding printk
>>
>>
>> Signed-off-by: Sudip Mukherjee
>> ---
>>
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
> printk replaced with corresponding dev_*
> fixed two broken user-visible strings used by the corresponding printk
>
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/tty/serial/serial_core.c | 19 ++-
> 1 file changed, 10
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee
---
drivers/tty/serial/serial_core.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/tty/serial/serial_core.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/tty/serial/serial_core.c | 19 ++-
1
On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby jsl...@suse.cz wrote:
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
On Mon, Jul 28, 2014 at 08:28:01PM +0530, Sudip Mukherjee wrote:
> printk replaced with corresponding pr_*
> fixed two broken user-visible strings used by the printk
Can you change to use dev_err() instead? That would help identify the
device and driver causing this problem better.
thanks,
printk replaced with corresponding pr_*
fixed two broken user-visible strings used by the printk
Signed-off-by: Sudip Mukherjee
---
drivers/tty/serial/serial_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c
printk replaced with corresponding pr_*
fixed two broken user-visible strings used by the printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/tty/serial/serial_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git
On Mon, Jul 28, 2014 at 08:28:01PM +0530, Sudip Mukherjee wrote:
printk replaced with corresponding pr_*
fixed two broken user-visible strings used by the printk
Can you change to use dev_err() instead? That would help identify the
device and driver causing this problem better.
thanks,
greg
20 matches
Mail list logo
