Re: Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-10-02 Thread Greg Kroah-Hartman
On Tue, Oct 02, 2018 at 09:36:50AM +0800, 钱君 wrote: > > > I have changed the description content, please refer to the patch file, > thanks a lot I can not apply patches from attachments like this, please resend it properly and I will be glad to review it. thanks, greg k-h

Re: Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-10-02 Thread Greg Kroah-Hartman
On Tue, Oct 02, 2018 at 09:36:50AM +0800, 钱君 wrote: > > > I have changed the description content, please refer to the patch file, > thanks a lot I can not apply patches from attachments like this, please resend it properly and I will be glad to review it. thanks, greg k-h

Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-10-01 Thread Uwe Kleine-König
Hello, On Mon, Aug 27, 2018 at 07:49:04AM -0700, jun qian wrote: > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR. "not appropriate" is a bit strong. It's not as optimal as it

Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-10-01 Thread Uwe Kleine-König
Hello, On Mon, Aug 27, 2018 at 07:49:04AM -0700, jun qian wrote: > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR. "not appropriate" is a bit strong. It's not as optimal as it

Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-08-28 Thread Barry Song
jun qian 于2018年8月27日周一 下午10:49写道: > > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR. > > Signed-off-by: jun qian many discussions have been done with jun in wechat regarding

Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-08-28 Thread Barry Song
jun qian 于2018年8月27日周一 下午10:49写道: > > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR. > > Signed-off-by: jun qian many discussions have been done with jun in wechat regarding

[PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-08-27 Thread jun qian
Before the program enters the uart ISR, the local interrupt has been disabled by the system, so it's not appropriate to use spin_lock_irqsave interface in the ISR. Signed-off-by: jun qian --- drivers/tty/serial/imx.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-)

[PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-08-27 Thread jun qian
Before the program enters the uart ISR, the local interrupt has been disabled by the system, so it's not appropriate to use spin_lock_irqsave interface in the ISR. Signed-off-by: jun qian --- drivers/tty/serial/imx.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-)