Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-24 Thread Felipe Balbi
On Tue, Mar 24, 2015 at 11:37:43AM -0500, Felipe Balbi wrote: > On Fri, Mar 20, 2015 at 02:27:40PM +, Sudeep Holla wrote: > > Hi Laurent, > > > > On 20/03/15 14:20, Laurent Pinchart wrote: > > >Hi Sudeep, > > > > > >Thank you for the patch. > > > > > >On Friday 20 March 2015 11:42:17 Sudeep

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-24 Thread Felipe Balbi
On Fri, Mar 20, 2015 at 02:27:40PM +, Sudeep Holla wrote: > Hi Laurent, > > On 20/03/15 14:20, Laurent Pinchart wrote: > >Hi Sudeep, > > > >Thank you for the patch. > > > >On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: > >>Commit a124820de5fd ("usb: isp1760: fix possible deadlock in >

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-24 Thread Felipe Balbi
On Fri, Mar 20, 2015 at 02:27:40PM +, Sudeep Holla wrote: Hi Laurent, On 20/03/15 14:20, Laurent Pinchart wrote: Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: Commit a124820de5fd (usb: isp1760: fix possible deadlock in isp1760_udc_irq)

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-24 Thread Felipe Balbi
On Tue, Mar 24, 2015 at 11:37:43AM -0500, Felipe Balbi wrote: On Fri, Mar 20, 2015 at 02:27:40PM +, Sudeep Holla wrote: Hi Laurent, On 20/03/15 14:20, Laurent Pinchart wrote: Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: Commit

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Sudeep Holla
Hi Laurent, On 20/03/15 14:20, Laurent Pinchart wrote: Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: Commit a124820de5fd ("usb: isp1760: fix possible deadlock in isp1760_udc_irq") replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}.

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Laurent Pinchart
Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: > Commit a124820de5fd ("usb: isp1760: fix possible deadlock in > isp1760_udc_irq") replaced spin_{un,}lock with > spin_{un,}lock_irq{save,restore}. However it missed an error path resulting > in the smatch

[PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Sudeep Holla
Commit a124820de5fd ("usb: isp1760: fix possible deadlock in isp1760_udc_irq") replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}. However it missed an error path resulting in the smatch warning as below: drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: inconsistent

[PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Sudeep Holla
Commit a124820de5fd (usb: isp1760: fix possible deadlock in isp1760_udc_irq) replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}. However it missed an error path resulting in the smatch warning as below: drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: inconsistent

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Sudeep Holla
Hi Laurent, On 20/03/15 14:20, Laurent Pinchart wrote: Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: Commit a124820de5fd (usb: isp1760: fix possible deadlock in isp1760_udc_irq) replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}. However

Re: [PATCH] usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

2015-03-20 Thread Laurent Pinchart
Hi Sudeep, Thank you for the patch. On Friday 20 March 2015 11:42:17 Sudeep Holla wrote: Commit a124820de5fd (usb: isp1760: fix possible deadlock in isp1760_udc_irq) replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}. However it missed an error path resulting in the smatch warning