Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-15 Thread Andreas Kemnade
On Wed, 7 Feb 2018 14:37:00 -0600 Bin Liu wrote: > On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > > Hi, > > > > On Tue, 6 Feb 2018 12:46:05 -0600 > > Bin Liu wrote: > > > > > Hi, > > > > > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-15 Thread Andreas Kemnade
On Wed, 7 Feb 2018 14:37:00 -0600 Bin Liu wrote: > On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > > Hi, > > > > On Tue, 6 Feb 2018 12:46:05 -0600 > > Bin Liu wrote: > > > > > Hi, > > > > > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > > > On

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-07 Thread Bin Liu
On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > Hi, > > On Tue, 6 Feb 2018 12:46:05 -0600 > Bin Liu wrote: > > > Hi, > > > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > > On dm3730 there are enumeration problems after resume. > > >

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-07 Thread Bin Liu
On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > Hi, > > On Tue, 6 Feb 2018 12:46:05 -0600 > Bin Liu wrote: > > > Hi, > > > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > > On dm3730 there are enumeration problems after resume. > > > Investigation led

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-07 Thread Bin Liu
On Tue, Feb 06, 2018 at 10:47:25AM -0800, Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-07 Thread Bin Liu
On Tue, Feb 06, 2018 at 10:47:25AM -0800, Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend (because it > > was

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 10:47:25 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 10:47:25 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend (because it > > was enabled

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Tony Lindgren
* Andreas Kemnade [180127 08:34]: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Tony Lindgren
* Andreas Kemnade [180127 08:34]: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in > musb_restore_context() so the pullup

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Bin Liu
Hi, On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Bin Liu
Hi, On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > On dm3730 there are enumeration problems after resume. > Investigation led to the cause that the MUSB_POWER_SOFTCONN > bit is not set. If it was set before suspend (because it > was enabled via musb_pullup()), it is set in >

[PATCH] usb: musb: fix enumeration after resume

2018-01-27 Thread Andreas Kemnade
On dm3730 there are enumeration problems after resume. Investigation led to the cause that the MUSB_POWER_SOFTCONN bit is not set. If it was set before suspend (because it was enabled via musb_pullup()), it is set in musb_restore_context() so the pullup is enabled. But then musb_start() is called

[PATCH] usb: musb: fix enumeration after resume

2018-01-27 Thread Andreas Kemnade
On dm3730 there are enumeration problems after resume. Investigation led to the cause that the MUSB_POWER_SOFTCONN bit is not set. If it was set before suspend (because it was enabled via musb_pullup()), it is set in musb_restore_context() so the pullup is enabled. But then musb_start() is called