Re: [PATCH] usb: storage: alauda: Clean up if function returned NULL on failure

2016-09-27 Thread Greg KH
On Tue, Sep 13, 2016 at 10:48:51PM +0530, Amit Ghadge wrote: > Some functions return NULL on failure, used !x instead of x==NULL. > > Signed-off-by: Amit Ghadge > --- > drivers/usb/storage/alauda.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Same

Re: [PATCH] usb: storage: alauda: Clean up if function returned NULL on failure

2016-09-27 Thread Greg KH
On Tue, Sep 13, 2016 at 10:48:51PM +0530, Amit Ghadge wrote: > Some functions return NULL on failure, used !x instead of x==NULL. > > Signed-off-by: Amit Ghadge > --- > drivers/usb/storage/alauda.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Same mailing list comment

[PATCH] usb: storage: alauda: Clean up if function returned NULL on failure

2016-09-13 Thread Amit Ghadge
Some functions return NULL on failure, used !x instead of x==NULL. Signed-off-by: Amit Ghadge --- drivers/usb/storage/alauda.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c

[PATCH] usb: storage: alauda: Clean up if function returned NULL on failure

2016-09-13 Thread Amit Ghadge
Some functions return NULL on failure, used !x instead of x==NULL. Signed-off-by: Amit Ghadge --- drivers/usb/storage/alauda.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index 1d8b03c..8f25bc8