On Fri, Jul 26, 2013 at 01:56:19PM +0800, Barry Song wrote:
> 2013/7/18 Felipe Balbi :
> > On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
> >> Hi Felipe,
> >>
> >> Thanks, I'll test the patch.
> >>
> >> But sysfs_notify(&gadget->dev.kobj, NULL, "status"), status or state ?
> >> I notice
2013/7/18 Felipe Balbi :
> On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
>> Hi Felipe,
>>
>> Thanks, I'll test the patch.
>>
>> But sysfs_notify(&gadget->dev.kobj, NULL, "status"), status or state ?
>> I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
>
> good eyes
2013/7/18 Greg KH :
> On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
>> Hi,
>>
>> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> > > The question is since we default GADGET, so the g_mass_storage.ko is
>> > > installed early but connecting to a host PC
>> > > is randomly
Hi,
On Thu, Jul 18, 2013 at 09:50:37AM -0400, Alan Stern wrote:
> On Thu, 18 Jul 2013, Felipe Balbi wrote:
>
> > > > yes. Only the UDC driver knows when the controller is moving among those
> > > > states.
> > >
> > > Not quite. Only the gadget driver knows when the transition between
> > > AD
>
> On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen
> wrote:
> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> >> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> >> > Hi Greg,
> >> >
> >> > The USB on our platform can change roles between HOST and GADGET,
> but
> >> > it
On Thu, 18 Jul 2013, Felipe Balbi wrote:
> > > yes. Only the UDC driver knows when the controller is moving among those
> > > states.
> >
> > Not quite. Only the gadget driver knows when the transition between
> > ADDRESS and CONFIGURED occurs. This should be added to composite.c.
>
> that's
On Thu, Jul 18, 2013 at 06:54:38PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> Here's the patch. If you are OK with it, I'll send it to the list formally.
> Thanks.
>
> -
>
> usb: gadget: udc-core: make
Hi Felipe,
Here's the patch. If you are OK with it, I'll send it to the list formally.
Thanks.
-
usb: gadget: udc-core: make udc state attribute name consistent
The name of udc state attribute file u
On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> Thanks, I'll test the patch.
>
> But sysfs_notify(&gadget->dev.kobj, NULL, "status"), status or state ?
> I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
good eyes, please send a patch which I'll q
Hi,
On Thu, Jul 18, 2013 at 11:40:41AM +0300, Felipe Balbi wrote:
> > >> >> > The question is since we default GADGET, so the g_mass_storage.ko is
> > >> >> > installed early but connecting to a host PC
> > >> >> > is randomly, But the udev has no idea when a host PC connects our
> > >> >> > devi
Hi Felipe,
Thanks, I'll test the patch.
But sysfs_notify(&gadget->dev.kobj, NULL, "status"), status or state ?
I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL)
On Thu, Jul 18, 2013 at 4:40 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wan
Hi,
On Thu, Jul 18, 2013 at 04:33:43PM +0800, Rong Wang wrote:
> On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi wrote:
> > On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> >> Hi Felipe,
> >>
> >> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> >> > Hi,
> >> >
> >> > On Mon, Jul
On Wed, Jul 17, 2013 at 9:27 PM, Felipe Balbi wrote:
> On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
>> Hi Felipe,
>>
>> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> >> > The question is since we d
Hi Peter,
On Wed, Jul 17, 2013 at 10:36 AM, Peter Chen wrote:
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
>> > Hi Greg,
>> >
>> > The USB on our platform can change roles between HOST and GADGET, but
>> > it is not capa
Hi,
On Wed, Jul 17, 2013 at 11:37:35AM -0400, Alan Stern wrote:
> On Wed, 17 Jul 2013, Felipe Balbi wrote:
>
> > On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> > > Hi Felipe,
> > >
> > > On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > > > Hi,
> > > >
> > > > On Mon, Jul 1
On Wed, Jul 17, 2013 at 10:57:06AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > > The question is since we default GADGET, so the g_mass_storage.ko is
> > > installed early but connecting to a host PC
> > > is randomly, But the udev has no idea
On Wed, 17 Jul 2013, Felipe Balbi wrote:
> On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> > Hi Felipe,
> >
> > On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > >> > The question is since we defau
On Wed, Jul 17, 2013 at 09:04:54PM +0800, Rong Wang wrote:
> Hi Felipe,
>
> On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> >> > The question is since we default GADGET, so the g_mass_storage.ko is
> >> > installed ea
Hi Felipe,
On Wed, Jul 17, 2013 at 3:57 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
>> > The question is since we default GADGET, so the g_mass_storage.ko is
>> > installed early but connecting to a host PC
>> > is randomly, But the udev has no idea
Hi,
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> > The question is since we default GADGET, so the g_mass_storage.ko is
> > installed early but connecting to a host PC
> > is randomly, But the udev has no idea when a host PC connects our device.
> >
> > So we consider it's reasonabl
Hi Greg,
On Tue, Jul 16, 2013 at 2:31 PM, Greg KH wrote:
> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
>> Hi Greg,
>>
>> The USB on our platform can change roles between HOST and GADGET, but
>> it is not capable of OTG.
>
> That kind of sounds like the definition of OTG :)
Yes. Bu
On Mon, Jul 15, 2013 at 11:31:17PM -0700, Greg KH wrote:
> On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> > Hi Greg,
> >
> > The USB on our platform can change roles between HOST and GADGET, but
> > it is not capable of OTG.
>
> That kind of sounds like the definition of OTG :)
>
>
On Tue, Jul 16, 2013 at 11:49:07AM +0800, Rong Wang wrote:
> Hi Greg,
>
> The USB on our platform can change roles between HOST and GADGET, but
> it is not capable of OTG.
That kind of sounds like the definition of OTG :)
> When the USB changes between roles the udev will run some scripts
> auto
Hi Greg,
The USB on our platform can change roles between HOST and GADGET, but
it is not capable of OTG.
When the USB changes between roles the udev will run some scripts
automatically according to the udev rules.
The default role is GADGET, and we bind the g_mass_storage to the USB
GADGET role.
On Mon, Jul 15, 2013 at 11:57:24AM +0800, Rong Wang wrote:
> usb: udc: add gadget state kobject uevent
>
> Add USB_UDC_STATE environment variable in udc uevent
> callback and trigger kobject_uevent in usb_gadget_set_state
> to inform the user-space the state of the gadget.
Why?
A
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang
diff --git a/drivers/usb/gadget/udc-core.c b/
usb: udc: add gadget state kobject uevent
Add USB_UDC_STATE environment variable in udc uevent
callback and trigger kobject_uevent in usb_gadget_set_state
to inform the user-space the state of the gadget.
Signed-off-by: Rong Wang
diff --git a/drivers/usb/gadget/udc-core.c b/
27 matches
Mail list logo