Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-22 Thread Maxime Ripard
Hi Shawn, Le 18/04/2013 16:48, Shawn Guo a écrit : > Copy Sascha. Ah, yes, sorry, I somehow got confused and thought you were the one that wrote the driver. I'll resend the patch. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-22 Thread Maxime Ripard
Hi Shawn, Le 18/04/2013 16:48, Shawn Guo a écrit : Copy Sascha. Ah, yes, sorry, I somehow got confused and thought you were the one that wrote the driver. I'll resend the patch. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Shawn Guo
Copy Sascha. Shawn On Thu, Apr 18, 2013 at 11:23:52AM +0200, Maxime Ripard wrote: > The current code always registers as a 32 bits display, and uses the > hardware to drop the MSB of each color to abjust to the interface width > used by the panel. > > This results on 18 bits (and probably 16

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Marek Vasut
Dear Maxime Ripard, > The current code always registers as a 32 bits display, and uses the > hardware to drop the MSB of each color to abjust to the interface width > used by the panel. > > This results on 18 bits (and probably 16 bits display as well) in colors > being displayed poorly, because

[PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Maxime Ripard
The current code always registers as a 32 bits display, and uses the hardware to drop the MSB of each color to abjust to the interface width used by the panel. This results on 18 bits (and probably 16 bits display as well) in colors being displayed poorly, because the MSB are obviously the most

[PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Maxime Ripard
The current code always registers as a 32 bits display, and uses the hardware to drop the MSB of each color to abjust to the interface width used by the panel. This results on 18 bits (and probably 16 bits display as well) in colors being displayed poorly, because the MSB are obviously the most

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Marek Vasut
Dear Maxime Ripard, The current code always registers as a 32 bits display, and uses the hardware to drop the MSB of each color to abjust to the interface width used by the panel. This results on 18 bits (and probably 16 bits display as well) in colors being displayed poorly, because the

Re: [PATCH] video: mxsfb: Fix colors display on lower color depth

2013-04-18 Thread Shawn Guo
Copy Sascha. Shawn On Thu, Apr 18, 2013 at 11:23:52AM +0200, Maxime Ripard wrote: The current code always registers as a 32 bits display, and uses the hardware to drop the MSB of each color to abjust to the interface width used by the panel. This results on 18 bits (and probably 16 bits