Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Ricardo Ribalda Delgado
Hello Sylwester I have just posted a new version. Please take a look to it, it should fix your issue. I havent tried it in hw because I am out of the office. Regards! On Sat, Oct 19, 2013 at 12:51 PM, Sylwester Nawrocki wrote: > On 10/19/2013 12:22 PM, Ricardo Ribalda Delgado wrote: >> >> On

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Sylwester Nawrocki
On 10/19/2013 12:22 PM, Ricardo Ribalda Delgado wrote: On Sat, Oct 19, 2013 at 11:55 AM, Sylwester Nawrocki wrote: > On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: >> >> vb2_fop_relase does not held the lock although it is modifying the >> queue->owner field. > [...] >> diff

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Ricardo Ribalda Delgado
Hello Sylwester On Sat, Oct 19, 2013 at 11:55 AM, Sylwester Nawrocki wrote: > Hi Ricardo, > > > On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: >> >> vb2_fop_relase does not held the lock although it is modifying the >> queue->owner field. > > [...] > >> diff --git

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Sylwester Nawrocki
Hi Ricardo, On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue->owner field. [...] diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 9fc4bab..3a961ee 100644 ---

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Sylwester Nawrocki
Hi Ricardo, On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue-owner field. [...] diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 9fc4bab..3a961ee 100644 ---

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Ricardo Ribalda Delgado
Hello Sylwester On Sat, Oct 19, 2013 at 11:55 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Ricardo, On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue-owner field. [...] diff --git

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Sylwester Nawrocki
On 10/19/2013 12:22 PM, Ricardo Ribalda Delgado wrote: On Sat, Oct 19, 2013 at 11:55 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 10/14/2013 09:41 AM, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue-owner field.

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-19 Thread Ricardo Ribalda Delgado
Hello Sylwester I have just posted a new version. Please take a look to it, it should fix your issue. I havent tried it in hw because I am out of the office. Regards! On Sat, Oct 19, 2013 at 12:51 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 10/19/2013 12:22 PM, Ricardo

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Marek Szyprowski
Hello, On 2013-10-14 09:41, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue->owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Hans Verkuil
On 10/14/13 09:41, Ricardo Ribalda Delgado wrote: > vb2_fop_relase does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video device via > read/write API: > >

[PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Ricardo Ribalda Delgado
vb2_fop_relase does not held the lock although it is modifying the queue->owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [ 308.297741] BUG: unable to handle kernel NULL pointer

[PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Ricardo Ribalda Delgado
vb2_fop_relase does not held the lock although it is modifying the queue-owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [ 308.297741] BUG: unable to handle kernel NULL pointer

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Hans Verkuil
On 10/14/13 09:41, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue-owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [

Re: [PATCH] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-14 Thread Marek Szyprowski
Hello, On 2013-10-14 09:41, Ricardo Ribalda Delgado wrote: vb2_fop_relase does not held the lock although it is modifying the queue-owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [