Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue->stream corruption and lockup

2007-02-21 Thread Adrian Bunk
On Tue, Jan 23, 2007 at 09:10:08PM -0200, Mauro Carvalho Chehab wrote: > Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu: > > I am pretty sure the bug is real, but the patch may be wrong, please review. > > > > We are doing ->buf_prepare(buf) before adding buf to q->stream list. This >

Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue-stream corruption and lockup

2007-02-21 Thread Adrian Bunk
On Tue, Jan 23, 2007 at 09:10:08PM -0200, Mauro Carvalho Chehab wrote: Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu: I am pretty sure the bug is real, but the patch may be wrong, please review. We are doing -buf_prepare(buf) before adding buf to q-stream list. This means

Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue->stream corruption and lockup

2007-01-23 Thread Mauro Carvalho Chehab
Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu: > I am pretty sure the bug is real, but the patch may be wrong, please review. > > We are doing ->buf_prepare(buf) before adding buf to q->stream list. This > means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer. >

[PATCH] videobuf_qbuf: fix? possible videobuf_queue->stream corruption and lockup

2007-01-23 Thread Oleg Nesterov
I am pretty sure the bug is real, but the patch may be wrong, please review. We are doing ->buf_prepare(buf) before adding buf to q->stream list. This means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> ---

[PATCH] videobuf_qbuf: fix? possible videobuf_queue-stream corruption and lockup

2007-01-23 Thread Oleg Nesterov
I am pretty sure the bug is real, but the patch may be wrong, please review. We are doing -buf_prepare(buf) before adding buf to q-stream list. This means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer. Signed-off-by: Oleg Nesterov [EMAIL PROTECTED] ---

Re: [PATCH] videobuf_qbuf: fix? possible videobuf_queue-stream corruption and lockup

2007-01-23 Thread Mauro Carvalho Chehab
Em Ter, 2007-01-23 às 20:57 +0300, Oleg Nesterov escreveu: I am pretty sure the bug is real, but the patch may be wrong, please review. We are doing -buf_prepare(buf) before adding buf to q-stream list. This means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.