Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Rusty Russell
Kent Overstreet writes: > On Fri, Sep 07, 2012 at 09:10:25AM +0930, Rusty Russell wrote: >> Kent Overstreet writes: >> >> > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: >> >> On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: >> >> > Do you not understand

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Fri, Sep 07, 2012 at 09:10:25AM +0930, Rusty Russell wrote: > Kent Overstreet writes: > > > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: > >> On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: > >> > Do you not understand the difference between depends an

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Rusty Russell
Kent Overstreet writes: > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: >> On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: >> > Do you not understand the difference between depends an selects? >> > Or did you not read my original mail? Now you're getting

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 03:31:44AM -0700, Kent Overstreet wrote: > On Thu, Sep 06, 2012 at 01:18:43PM +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: > > > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Sep

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 01:18:43PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: > > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: > > > > On Thu, Sep

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: > On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: > > > On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Sep

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: > > On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: > > > > On Tue, Sep

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: > On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: > > > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: > > > > Kent Overstreet

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: > > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: > > > Kent Overstreet writes: > > > > > > > CONFIG_VIRTIO isn't exposed, everything else is

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: > > Kent Overstreet writes: > > > > > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > > > instead. > > > > This is a slight

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: > Kent Overstreet writes: > > > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > > instead. > > This is a slight mis-understanding. It's supposed to be selected by > the particular driver, probably virtio_pci

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver,

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote: On Tue, Sep 04, 2012

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Thu, Sep 06, 2012 at 01:18:43PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2012 at 03:31:44AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 01:18:43PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 03:02:48AM -0700, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Rusty Russell
Kent Overstreet koverstr...@google.com writes: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: Do you not understand the difference between depends an selects? Or did you not read my original mail? Now

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Kent Overstreet
On Fri, Sep 07, 2012 at 09:10:25AM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote: Do you not understand the difference between

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-06 Thread Rusty Russell
Kent Overstreet koverstr...@google.com writes: On Fri, Sep 07, 2012 at 09:10:25AM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote:

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: >> Kent Overstreet writes: >> >> > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it >> > instead. >> >> This is a slight mis-understanding. It's supposed to be selected by >> the

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Michael S. Tsirkin
On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: > Kent Overstreet writes: > > > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > > instead. > > This is a slight mis-understanding. It's supposed to be selected by > the particular driver, probably virtio_pci

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 01:54:07PM +0800, Asias He wrote: > On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: > > On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: > >> On 09/04/2012 02:23 PM, Rusty Russell wrote: > >>> Kent Overstreet writes: > >>> > CONFIG_VIRTIO isn't exposed,

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 01:54:07PM +0800, Asias He wrote: On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: On 09/04/2012 02:23 PM, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed,

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-05 Thread Michael S. Tsirkin
On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver,

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: >> On 09/04/2012 02:23 PM, Rusty Russell wrote: >>> Kent Overstreet writes: >>> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. >>> >>> This is a

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: > On 09/04/2012 02:23 PM, Rusty Russell wrote: > > Kent Overstreet writes: > > > >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > >> instead. > > > > This is a slight mis-understanding. It's supposed to be

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/04/2012 02:23 PM, Rusty Russell wrote: > Kent Overstreet writes: > >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it >> instead. > > This is a slight mis-understanding. It's supposed to be selected by > the particular driver, probably virtio_pci in your case.

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Kent Overstreet
On Mon, Sep 3, 2012 at 11:23 PM, Rusty Russell wrote: > Kent Overstreet writes: > >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it >> instead. > > This is a slight mis-understanding. It's supposed to be selected by > the particular driver, probably virtio_pci in your

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Rusty Russell
Kent Overstreet writes: > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it > instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver, probably virtio_pci in your case. Cheers, Rusty. -- To unsubscribe from this list: send the

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Rusty Russell
Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver, probably virtio_pci in your case. Cheers, Rusty. -- To unsubscribe from

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Kent Overstreet
On Mon, Sep 3, 2012 at 11:23 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to be selected by the particular

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/04/2012 02:23 PM, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to be selected by the particular driver, probably virtio_pci in

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: On 09/04/2012 02:23 PM, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a slight mis-understanding. It's supposed to

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: On 09/04/2012 02:23 PM, Rusty Russell wrote: Kent Overstreet koverstr...@google.com writes: CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. This is a

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-02 Thread Kent Overstreet
Whoops, need VIRTIO_RING too >From 79dc9ae40e40cefd6079e4197cac858a1d59e1d8 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Sun, 2 Sep 2012 21:44:37 -0700 Subject: [PATCH] virtio-blk: Fix kconfig option CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. Sig

[PATCH] virtio-blk: Fix kconfig option

2012-09-02 Thread Kent Overstreet
CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. Signed-off-by: Kent Overstreet --- drivers/block/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index a796407..d4e1d12 100644 ---

[PATCH] virtio-blk: Fix kconfig option

2012-09-02 Thread Kent Overstreet
CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead. Signed-off-by: Kent Overstreet koverstr...@google.com --- drivers/block/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-02 Thread Kent Overstreet
Whoops, need VIRTIO_RING too From 79dc9ae40e40cefd6079e4197cac858a1d59e1d8 Mon Sep 17 00:00:00 2001 From: Kent Overstreet koverstr...@google.com Date: Sun, 2 Sep 2012 21:44:37 -0700 Subject: [PATCH] virtio-blk: Fix kconfig option CONFIG_VIRTIO isn't exposed, everything else is supposed to select