Re: [PATCH] vt: properly ignore xterm-256 colour codes

2013-09-13 Thread David Herrmann
Hi On Thu, Sep 12, 2013 at 3:24 PM, Adam Borowski wrote: > On Thu, Sep 12, 2013 at 02:37:26PM +0200, David Herrmann wrote: >> On Mon, Sep 9, 2013 at 6:46 PM, Adam Borowski wrote: >> > On Mon, Sep 09, 2013 at 05:53:19PM +0200, David Herrmann wrote: >> > [...] >> >> Btw., you should put Greg Kroah

Re: [PATCH] vt: properly ignore xterm-256 colour codes

2013-09-12 Thread Adam Borowski
On Thu, Sep 12, 2013 at 02:37:26PM +0200, David Herrmann wrote: > On Mon, Sep 9, 2013 at 6:46 PM, Adam Borowski wrote: > > On Mon, Sep 09, 2013 at 05:53:19PM +0200, David Herrmann wrote: > > [...] > >> Btw., you should put Greg Kroah-Hartman and Andrew Morton on CC. Both > >> are the most likely

Re: [PATCH] vt: properly ignore xterm-256 colour codes

2013-09-12 Thread David Herrmann
Hi Adam On Mon, Sep 9, 2013 at 6:46 PM, Adam Borowski wrote: > On Mon, Sep 09, 2013 at 05:53:19PM +0200, David Herrmann wrote: >> On Fri, Jul 12, 2013 at 10:23 PM, Adam Borowski wrote: >> > + i++; >> > + if (i > vc->vc_npar) >> >> This

Re: [PATCH] vt: properly ignore xterm-256 colour codes

2013-09-09 Thread Adam Borowski
On Mon, Sep 09, 2013 at 05:53:19PM +0200, David Herrmann wrote: > On Fri, Jul 12, 2013 at 10:23 PM, Adam Borowski wrote: > > drivers/tty/vt/vt.c | 26 -- > > 1 file changed, 20 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c > >

Re: [PATCH] vt: properly ignore xterm-256 colour codes

2013-09-09 Thread David Herrmann
Hi On Fri, Jul 12, 2013 at 10:23 PM, Adam Borowski wrote: > This is not a bug on our side, but a misdesign in ITU T.416, yet with > all popular terminals supporting these codes, people consider this to > be a bug in Linux. By breaking the design principles behind SGR codes > (gracefully ignoring

[PATCH] vt: properly ignore xterm-256 colour codes

2013-09-08 Thread Adam Borowski
This is not a bug on our side, but a misdesign in ITU T.416, yet with all popular terminals supporting these codes, people consider this to be a bug in Linux. By breaking the design principles behind SGR codes (gracefully ignoring unsupported ones should not require knowing about them), 256 colour