Re: [PATCH] watchdog: Fix runtime PM imbalance on error
On 5/21/20 1:01 AM, Dinghao Liu wrote: > When watchdog_register_device() returns an error code, > a pairing runtime PM usage counter decrement is needed > to keep the counter balanced. > > Signed-off-by: Dinghao Liu Reviewed-by: Guenter Roeck > --- > drivers/watchdog/omap_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c > index 9b91882fe3c4..1616f93dfad7 100644 > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -273,6 +273,7 @@ static int omap_wdt_probe(struct platform_device *pdev) > > ret = watchdog_register_device(>wdog); > if (ret) { > + pm_runtime_put(wdev->dev); > pm_runtime_disable(wdev->dev); > return ret; > } >
[PATCH] watchdog: Fix runtime PM imbalance on error
When watchdog_register_device() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/watchdog/omap_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index 9b91882fe3c4..1616f93dfad7 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -273,6 +273,7 @@ static int omap_wdt_probe(struct platform_device *pdev) ret = watchdog_register_device(>wdog); if (ret) { + pm_runtime_put(wdev->dev); pm_runtime_disable(wdev->dev); return ret; } -- 2.17.1