Re: [PATCH] x86/CPU: Use correct macros for Cyrix calls on Geode processors

2019-03-06 Thread Thomas Gleixner
Matthew, On Wed, 6 Mar 2019, Matthew Whitehead wrote: > There are comments in processor-cyrix.h advising you to _not_ make calls > using the deprecated macros in this style: > > setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); > > This is because it expands the macro into a

[PATCH] x86/CPU: Use correct macros for Cyrix calls on Geode processors

2019-03-06 Thread Matthew Whitehead
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2,