Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-08 Thread Bityutskiy, Artem
On Sat, 2013-06-08 at 14:15 +0300, Artem Bityutskiy wrote: > On Wed, 2013-05-22 at 10:43 +0100, Matt Fleming wrote: > > From: Matt Fleming > > > > pcibios_add_device() assumes that the physical addresses stored in > > setup_data are accessible via the direct kernel mapping, and that > > calling

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-08 Thread Artem Bityutskiy
On Wed, 2013-05-22 at 10:43 +0100, Matt Fleming wrote: > From: Matt Fleming > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the direct kernel mapping, and that > calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 >

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-08 Thread Artem Bityutskiy
On Wed, 2013-05-22 at 10:43 +0100, Matt Fleming wrote: From: Matt Fleming matt.flem...@intel.com pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that calling phys_to_virt() is valid. This isn't guaranteed to be

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-08 Thread Bityutskiy, Artem
On Sat, 2013-06-08 at 14:15 +0300, Artem Bityutskiy wrote: On Wed, 2013-05-22 at 10:43 +0100, Matt Fleming wrote: From: Matt Fleming matt.flem...@intel.com pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-05 Thread Bjorn Helgaas
4533162487fa1e4bc23877a8a502 Mon Sep 17 00:00:00 2001 > From: Matt Fleming > Date: Wed, 22 May 2013 09:56:23 +0100 > Subject: [PATCH] x86/PCI: setup data may be in highmem > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-05 Thread Matt Fleming
I've seen. I've included the new patch below. Would you prefer a proper submission? --- >From 7a82fbe1d0c74533162487fa1e4bc23877a8a502 Mon Sep 17 00:00:00 2001 From: Matt Fleming Date: Wed, 22 May 2013 09:56:23 +0100 Subject: [PATCH] x86/PCI: setup data may be in highmem pcibios_add_devi

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-05 Thread Matt Fleming
. I've included the new patch below. Would you prefer a proper submission? --- From 7a82fbe1d0c74533162487fa1e4bc23877a8a502 Mon Sep 17 00:00:00 2001 From: Matt Fleming matt.flem...@intel.com Date: Wed, 22 May 2013 09:56:23 +0100 Subject: [PATCH] x86/PCI: setup data may be in highmem

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-06-05 Thread Bjorn Helgaas
Mon Sep 17 00:00:00 2001 From: Matt Fleming matt.flem...@intel.com Date: Wed, 22 May 2013 09:56:23 +0100 Subject: [PATCH] x86/PCI: setup data may be in highmem pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 10:48 AM, Matthew Garrett wrote: > On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: >> On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: >> > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> >> pcibios_add_device() is mostly called at boot-time,

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Matthew Garrett
On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: > On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: > > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: > >> pcibios_add_device() is mostly called at boot-time, when > >> early_ioremap() probably works well. But it's also

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 5:36 AM, Matt Fleming wrote: > On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: >> pcibios_add_device() is mostly called at boot-time, when >> early_ioremap() probably works well. But it's also called when we >> hot-add devices later, and it looks like early_ioremap()

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Matt Fleming
On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: > pcibios_add_device() is mostly called at boot-time, when > early_ioremap() probably works well. But it's also called when we > hot-add devices later, and it looks like early_ioremap() will then > generate warnings because "system_state !=

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Matt Fleming
On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: pcibios_add_device() is mostly called at boot-time, when early_ioremap() probably works well. But it's also called when we hot-add devices later, and it looks like early_ioremap() will then generate warnings because system_state !=

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 5:36 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: pcibios_add_device() is mostly called at boot-time, when early_ioremap() probably works well. But it's also called when we hot-add devices later, and it looks like

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Matthew Garrett
On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: On Tue, May 28, 2013 at 5:36 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: pcibios_add_device() is mostly called at boot-time, when early_ioremap() probably works well. But

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-28 Thread Bjorn Helgaas
On Tue, May 28, 2013 at 10:48 AM, Matthew Garrett mj...@srcf.ucam.org wrote: On Tue, May 28, 2013 at 10:31:51AM -0600, Bjorn Helgaas wrote: On Tue, May 28, 2013 at 5:36 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 24 May, at 08:38:10AM, Bjorn Helgaas wrote: pcibios_add_device() is

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-24 Thread Bjorn Helgaas
On Wed, May 22, 2013 at 3:43 AM, Matt Fleming wrote: > From: Matt Fleming > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the direct kernel mapping, and that > calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 > where

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-24 Thread Bjorn Helgaas
On Wed, May 22, 2013 at 3:43 AM, Matt Fleming m...@console-pimps.org wrote: From: Matt Fleming matt.flem...@intel.com pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that calling phys_to_virt() is valid. This

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-23 Thread H. Peter Anvin
On 05/22/2013 02:43 AM, Matt Fleming wrote: > From: Matt Fleming > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the direct kernel mapping, and that > calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 > where the

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-23 Thread H. Peter Anvin
On 05/22/2013 02:43 AM, Matt Fleming wrote: From: Matt Fleming matt.flem...@intel.com pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that calling phys_to_virt() is valid. This isn't guaranteed to be true on x86

[PATCH] x86/PCI: setup data may be in highmem

2013-05-22 Thread Matt Fleming
From: Matt Fleming pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 where the direct mapping range is much smaller than on x86-64. Calling

[PATCH] x86/PCI: setup data may be in highmem

2013-05-22 Thread Matt Fleming
From: Matt Fleming matt.flem...@intel.com pcibios_add_device() assumes that the physical addresses stored in setup_data are accessible via the direct kernel mapping, and that calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 where the direct mapping range is much smaller