Re: [PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup

2017-03-01 Thread Dou Liyang
Dear Ingo, At 03/01/2017 05:04 PM, Ingo Molnar wrote: [...] + pr_info("Not init interrupt remapping due to skipped IO-APIC setup\n"); So you replaced a perfectly readable kernel message: - pr_info("Not enabling interrupt remapping due to skipped IO-APIC setup\n")

Re: [PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup

2017-03-01 Thread Ingo Molnar
* Dou Liyang wrote: > As the commit 2e63ad4bd5dd ("x86/apic: Do not init irq remapping > if ioapic is disabled") added the judgement of skipped IO APIC > setup at the beginning of enable_IR_x2apic(). It may be redundant > that we check it again when we try to enable the interrupt mapping. > > S

[PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup

2017-02-23 Thread Dou Liyang
As the commit 2e63ad4bd5dd ("x86/apic: Do not init irq remapping if ioapic is disabled") added the judgement of skipped IO APIC setup at the beginning of enable_IR_x2apic(). It may be redundant that we check it again when we try to enable the interrupt mapping. So, remove the one in try_to_enable_