Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 07/06/17 at 09:28pm, Baoquan He wrote: > > > Do you mean the handling in boot/compressed/head_64.S? Whatever it does, > > > it's only for physical address. The virtual address mapping is not > > > touched. Here virt_addr respresents the offset between > > > 0x8000,

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 07/06/17 at 09:28pm, Baoquan He wrote: > > > Do you mean the handling in boot/compressed/head_64.S? Whatever it does, > > > it's only for physical address. The virtual address mapping is not > > > touched. Here virt_addr respresents the offset between > > > 0x8000,

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 07/05/17 at 12:06pm, Kees Cook wrote: > On Tue, Jun 27, 2017 at 4:24 PM, Baoquan He wrote: > > Below code was added to fix the kexec/kdump kernel with kaslr disabled, > > at that time kernel kaslr physical address and virtual address > > randomization are coupled. What it was

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 07/05/17 at 12:06pm, Kees Cook wrote: > On Tue, Jun 27, 2017 at 4:24 PM, Baoquan He wrote: > > Below code was added to fix the kexec/kdump kernel with kaslr disabled, > > at that time kernel kaslr physical address and virtual address > > randomization are coupled. What it was doing is to

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On Tue, Jun 27, 2017 at 4:24 PM, Baoquan He wrote: > Hi Kees, > > On 06/27/17 at 03:42pm, Kees Cook wrote: >> On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: >> > Kdump kernel will reset to firmware after crash is trigered when >> > crashkernel=xxM,high is

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On Tue, Jun 27, 2017 at 4:24 PM, Baoquan He wrote: > Hi Kees, > > On 06/27/17 at 03:42pm, Kees Cook wrote: >> On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: >> > Kdump kernel will reset to firmware after crash is trigered when >> > crashkernel=xxM,high is added to kernel command line. Kexec

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 06/28/17 at 07:24am, Baoquan He wrote: > Hi Kees, > > On 06/27/17 at 03:42pm, Kees Cook wrote: > > On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > > > Kdump kernel will reset to firmware after crash is trigered when > > > crashkernel=xxM,high is added to kernel command

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 06/28/17 at 07:24am, Baoquan He wrote: > Hi Kees, > > On 06/27/17 at 03:42pm, Kees Cook wrote: > > On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > > > Kdump kernel will reset to firmware after crash is trigered when > > > crashkernel=xxM,high is added to kernel command line. Kexec has

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Hi Kees, On 06/27/17 at 03:42pm, Kees Cook wrote: > On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > > Kdump kernel will reset to firmware after crash is trigered when > > crashkernel=xxM,high is added to kernel command line. Kexec has the > > same phenomenon. This only

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Hi Kees, On 06/27/17 at 03:42pm, Kees Cook wrote: > On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > > Kdump kernel will reset to firmware after crash is trigered when > > crashkernel=xxM,high is added to kernel command line. Kexec has the > > same phenomenon. This only happened on system

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only happened on system with kaslr code > compiled in and kernel

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On Sat, Jun 24, 2017 at 7:25 AM, Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only happened on system with kaslr code > compiled in and kernel option 'nokaslr'is

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 06/27/17 at 10:34am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > As you suggested, we can add a checking to see if the virt_addr is > > bigger than 1G, and print warning if exceed or hang there with error > > message. > > Could you try a patch for that, and see whether

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

On 06/27/17 at 10:34am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > As you suggested, we can add a checking to see if the virt_addr is > > bigger than 1G, and print warning if exceed or hang there with error > > message. > > Could you try a patch for that, and see whether it catches this

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

* Baoquan He wrote: > As you suggested, we can add a checking to see if the virt_addr is > bigger than 1G, and print warning if exceed or hang there with error > message. Could you try a patch for that, and see whether it catches this particular bug? (before the fix is

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

* Baoquan He wrote: > As you suggested, we can add a checking to see if the virt_addr is > bigger than 1G, and print warning if exceed or hang there with error > message. Could you try a patch for that, and see whether it catches this particular bug? (before the fix is applied.) Could be a 2

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Hi Ingo, Thanks for looking into this patch! On 06/26/17 at 11:47am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > Kdump kernel will reset to firmware after crash is trigered when > > crashkernel=xxM,high is added to kernel command line. Kexec has the > > same phenomenon.

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Hi Ingo, Thanks for looking into this patch! On 06/26/17 at 11:47am, Ingo Molnar wrote: > > * Baoquan He wrote: > > > Kdump kernel will reset to firmware after crash is trigered when > > crashkernel=xxM,high is added to kernel command line. Kexec has the > > same phenomenon. This only

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

* Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only happened on system with kaslr code > compiled in and kernel option 'nokaslr'is added. Both

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

* Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only happened on system with kaslr code > compiled in and kernel option 'nokaslr'is added. Both of them works >

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Sorry, forgot adding Cc: before maintainers contact, NACK this patch and will repost. On 06/24/17 at 10:16pm, Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only

Re: [PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Sorry, forgot adding Cc: before maintainers contact, NACK this patch and will repost. On 06/24/17 at 10:16pm, Baoquan He wrote: > Kdump kernel will reset to firmware after crash is trigered when > crashkernel=xxM,high is added to kernel command line. Kexec has the > same phenomenon. This only

[PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Kdump kernel will reset to firmware after crash is trigered when crashkernel=xxM,high is added to kernel command line. Kexec has the same phenomenon. This only happened on system with kaslr code compiled in and kernel option 'nokaslr'is added. Both of them works well when kaslr is enabled. When

[PATCH] x86/boot/KASLR: Skip relocation handling in no kaslr case

Kdump kernel will reset to firmware after crash is trigered when crashkernel=xxM,high is added to kernel command line. Kexec has the same phenomenon. This only happened on system with kaslr code compiled in and kernel option 'nokaslr'is added. Both of them works well when kaslr is enabled. When