RE: [PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-27 Thread David Laight
From: Andrew Cooper > Sent: 26 November 2020 23:52 > > On 26/11/2020 19:15, Andy Lutomirski wrote: > > On Thu, Nov 26, 2020 at 11:07 AM Lukas Bulwahn > > wrote: > >> On Thu, Nov 26, 2020 at 6:16 PM Andrew Cooper > >> wrote: > >>> On 26/11/2020 11:54, Lukas Bulwahn wrote: > Commit

Re: [PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-26 Thread Andrew Cooper
On 26/11/2020 19:15, Andy Lutomirski wrote: > On Thu, Nov 26, 2020 at 11:07 AM Lukas Bulwahn > wrote: >> On Thu, Nov 26, 2020 at 6:16 PM Andrew Cooper >> wrote: >>> On 26/11/2020 11:54, Lukas Bulwahn wrote: Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally

Re: [PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-26 Thread Andy Lutomirski
On Thu, Nov 26, 2020 at 11:07 AM Lukas Bulwahn wrote: > > On Thu, Nov 26, 2020 at 6:16 PM Andrew Cooper > wrote: > > > > On 26/11/2020 11:54, Lukas Bulwahn wrote: > > > Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally > > > transformed a few 0x values to 0xf

Re: [PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-26 Thread Lukas Bulwahn
On Thu, Nov 26, 2020 at 6:16 PM Andrew Cooper wrote: > > On 26/11/2020 11:54, Lukas Bulwahn wrote: > > Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally > > transformed a few 0x values to 0xf (note: five times "f" instead of > > four) as part of the refactoring. > >

Re: [PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-26 Thread Andrew Cooper
On 26/11/2020 11:54, Lukas Bulwahn wrote: > Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally > transformed a few 0x values to 0xf (note: five times "f" instead of > four) as part of the refactoring. The transformation in that change is correct. Segment bases are 20

[PATCH] x86/cpu: correct values for GDT_ENTRY_INIT

2020-11-26 Thread Lukas Bulwahn
Commit 1e5de18278e6 ("x86: Introduce GDT_ENTRY_INIT()") unintentionally transformed a few 0x values to 0xf (note: five times "f" instead of four) as part of the refactoring. A quick check with: git show 1e5de18278e6 | grep "f" reveals all those 14 occurrences: 12 in