Re: [PATCH] x86/cpufeature: Remove __pure attribute to _static_cpu_has()

2019-03-07 Thread Borislav Petkov
Lemme preface this by saying that I've talked to gcc guys before doing this. On Thu, Mar 07, 2019 at 08:43:50AM -0800, h...@zytor.com wrote: > Uhm... (a) it is correct, even if the compiler doesn't use it now, it > allows the compiler to CSE it in the future; Well, the compiler won't CSE asm

Re: [PATCH] x86/cpufeature: Remove __pure attribute to _static_cpu_has()

2019-03-07 Thread hpa
On March 7, 2019 7:10:36 AM PST, Borislav Petkov wrote: >On Mon, Feb 11, 2019 at 12:32:41PM -0800, Nadav Amit wrote: >> BTW: the “__pure” attribute is useless when “__always_inline” is >used. >> Unless it is intended to be some sort of comment, of course. > >--- >From: Borislav Petkov >Date:

[PATCH] x86/cpufeature: Remove __pure attribute to _static_cpu_has()

2019-03-07 Thread Borislav Petkov
On Mon, Feb 11, 2019 at 12:32:41PM -0800, Nadav Amit wrote: > BTW: the “__pure” attribute is useless when “__always_inline” is used. > Unless it is intended to be some sort of comment, of course. --- From: Borislav Petkov Date: Thu, 7 Mar 2019 15:54:51 +0100 __pure is used to make gcc do Common