Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread Jürgen Groß
On 24.08.20 17:58, Andrew Cooper wrote: On 24/08/2020 16:21, pet...@infradead.org wrote: On Mon, Aug 24, 2020 at 03:22:06PM +0100, Andrew Cooper wrote: On 24/08/2020 11:14, pet...@infradead.org wrote: The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further improve user entry

Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread Andrew Cooper
On 24/08/2020 16:21, pet...@infradead.org wrote: > On Mon, Aug 24, 2020 at 03:22:06PM +0100, Andrew Cooper wrote: >> On 24/08/2020 11:14, pet...@infradead.org wrote: >>> The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further >>> improve user entry sanity checks") unconditionally

Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread peterz
On Mon, Aug 24, 2020 at 03:22:06PM +0100, Andrew Cooper wrote: > On 24/08/2020 11:14, pet...@infradead.org wrote: > > The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further > > improve user entry sanity checks") unconditionally triggers on my IVB > > machine because it does not

Re: [PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread Andrew Cooper
On 24/08/2020 11:14, pet...@infradead.org wrote: > The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further > improve user entry sanity checks") unconditionally triggers on my IVB > machine because it does not support SMAP. > > For !SMAP hardware we patch out CLAC/STAC instructions

[PATCH] x86/entry: Fix AC assertion

2020-08-24 Thread peterz
The WARN added in commit 3c73b81a9164 ("x86/entry, selftests: Further improve user entry sanity checks") unconditionally triggers on my IVB machine because it does not support SMAP. For !SMAP hardware we patch out CLAC/STAC instructions and thus if userspace sets AC, we'll still have it set