Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-10 Thread Pavel Machek
On Thu 2015-07-09 15:42:27, John Stoffel wrote: > > "Linus" == Linus Torvalds writes: > > Linus> On Thu, Jul 9, 2015 at 11:51 AM, Arjan van de Ven > wrote: > >> > >> I would rather do BOTH the default n AND the EXPERT > > Linus> That basically makes it impossible for "normal people" to te

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-10 Thread Ingo Molnar
* Linus Torvalds wrote: > [...] > > The one thing we might want to do is to rename the config option, simply to > make > sure that people who do "make oldconfig" will actually see the new question > and > hopefully pick the new default rather than just getting their old "y" without > even

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread John Stoffel
> "Linus" == Linus Torvalds writes: Linus> On Thu, Jul 9, 2015 at 11:51 AM, Arjan van de Ven wrote: >> >> I would rather do BOTH the default n AND the EXPERT Linus> That basically makes it impossible for "normal people" to test it. You Linus> have to mark yourself as expert, and then get

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Yuhong Bao
Andy Lutomirski kernel.org> writes: > > VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is > in use. The code is a big undocumented mess, it's a real PITA to > test, and it looks like a big chunk of vm86_32.c is dead code. It > also plays awful games with the entry asm. Don't

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Linus Torvalds
On Thu, Jul 9, 2015 at 11:51 AM, Arjan van de Ven wrote: > > I would rather do BOTH the default n AND the EXPERT That basically makes it impossible for "normal people" to test it. You have to mark yourself as expert, and then get the rest of the configuration right. Not a good idea. The kernel c

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Andy Lutomirski
On Thu, Jul 9, 2015 at 11:51 AM, Arjan van de Ven wrote: > On 7/9/2015 11:40 AM, Andy Lutomirski wrote: >> >> VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is >> in use. The code is a big undocumented mess, it's a real PITA to >> test, and it looks like a big chunk of vm86_32.

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Arjan van de Ven
On 7/9/2015 11:40 AM, Andy Lutomirski wrote: VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is in use. The code is a big undocumented mess, it's a real PITA to test, and it looks like a big chunk of vm86_32.c is dead code. It also plays awful games with the entry asm. No one

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Kees Cook
On Thu, Jul 9, 2015 at 11:40 AM, Andy Lutomirski wrote: > VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is > in use. The code is a big undocumented mess, it's a real PITA to > test, and it looks like a big chunk of vm86_32.c is dead code. It > also plays awful games with the

[PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

2015-07-09 Thread Andy Lutomirski
VM86 is entirely broken if ptrace, syscall auditing, or NOHZ_FULL is in use. The code is a big undocumented mess, it's a real PITA to test, and it looks like a big chunk of vm86_32.c is dead code. It also plays awful games with the entry asm. No one should be using it anyway. Use DOSBOX or KVM