Re: [PATCH] x86/mce: Save microcode revision in machine check records

2018-03-02 Thread Borislav Petkov
ubject: [PATCH] x86/MCE: Save microcode revision in machine check records Updating microcode used to be relatively rare. Now that it has become more common we should save the microcode version in a machine check record to make sure that those people looking at the error have this important informa

RE: [PATCH] x86/mce: Save microcode revision in machine check records

2018-03-01 Thread Luck, Tony
+ c = &cpu_data(m->cpu); Bother. Breaks on systems with >255 cpus because "cpu" is __u8. s/m->cpu/m->extcpu/ -Tony

[PATCH] x86/mce: Save microcode revision in machine check records

2018-03-01 Thread Tony Luck
Updating microcode used to be relatively rare. Now that it has become more common we should save the microcode version in a machine check record to make sure that those people looking at the error have this important information bundled with the rest of the logged information. Signed-off-by: Tony