Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-29 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 03:57:47PM -0800, Jeremy Fitzhardinge wrote: > Adrian Bunk wrote: > > This does not apply since we do not have a stable in-kernel API, and > > therefore changes to the in-kernel API can by definition not be > > regressions. > > > > 2.6.24 most likely contains hundreds of

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-29 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 03:57:47PM -0800, Jeremy Fitzhardinge wrote: Adrian Bunk wrote: This does not apply since we do not have a stable in-kernel API, and therefore changes to the in-kernel API can by definition not be regressions. 2.6.24 most likely contains hundreds of changes and

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: > This does not apply since we do not have a stable in-kernel API, and > therefore changes to the in-kernel API can by definition not be > regressions. > > 2.6.24 most likely contains hundreds of changes and removals of > in-kernel APIs that existed in 2.6.23. > > Are you

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 01:15:39PM -0800, Jeremy Fitzhardinge wrote: > Adrian Bunk wrote: > > On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: >... > >> 2. It's a regression from previous kernels, which would work these > >>modules even with CONFIG_PARAVIRT enabled. > >>

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: > On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: > >> ... >> Christoph Hellwig objects to this patch on the grounds that modules >> shouldn't be using these operations anyway. I don't think this is a >> particularly good reason to reject the patch, for

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Adrian Bunk
On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: >... > Christoph Hellwig objects to this patch on the grounds that modules > shouldn't be using these operations anyway. I don't think this is a > particularly good reason to reject the patch, for several reasons: > > 1. These

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Adrian Bunk
On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: ... Christoph Hellwig objects to this patch on the grounds that modules shouldn't be using these operations anyway. I don't think this is a particularly good reason to reject the patch, for several reasons: 1. These

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: ... Christoph Hellwig objects to this patch on the grounds that modules shouldn't be using these operations anyway. I don't think this is a particularly good reason to reject the patch, for several

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Adrian Bunk
On Wed, Nov 28, 2007 at 01:15:39PM -0800, Jeremy Fitzhardinge wrote: Adrian Bunk wrote: On Tue, Nov 27, 2007 at 02:57:30PM -0800, Jeremy Fitzhardinge wrote: ... 2. It's a regression from previous kernels, which would work these modules even with CONFIG_PARAVIRT enabled. ...

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-28 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: This does not apply since we do not have a stable in-kernel API, and therefore changes to the in-kernel API can by definition not be regressions. 2.6.24 most likely contains hundreds of changes and removals of in-kernel APIs that existed in 2.6.23. Are you seriously

[PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-27 Thread Jeremy Fitzhardinge
Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case. Tobias Powalowski <[EMAIL PROTECTED]> reports: > commit to .24 tree: >

[PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-27 Thread Jeremy Fitzhardinge
Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case. Tobias Powalowski [EMAIL PROTECTED] reports: commit to .24 tree:

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Takashi Iwai
At Mon, 19 Nov 2007 17:14:15 -0800, Jeremy Fitzhardinge wrote: > > Takashi Iwai wrote: > > I took at this problem (as I have an nvidia card on one of my > > workstations), and found out that the following suffer from > > EXPORT_SYMBOL_GPL changes: > > > > Which kernel version are you using?

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Jeremy Fitzhardinge
Takashi Iwai wrote: > I took at this problem (as I have an nvidia card on one of my > workstations), and found out that the following suffer from > EXPORT_SYMBOL_GPL changes: > Which kernel version are you using? This is different in .24-rc compared to .23. > * local_disable_irq(),

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Takashi Iwai
At Tue, 13 Nov 2007 16:51:04 -0800, Zachary Amsden wrote: > > On Tue, 2007-11-13 at 22:22 +, Christoph Hellwig wrote: > > On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: > > > Subject: x86/paravirt: revert exports to restore old behaviour > > > > > > Subdividing the

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Takashi Iwai
At Tue, 13 Nov 2007 16:51:04 -0800, Zachary Amsden wrote: On Tue, 2007-11-13 at 22:22 +, Christoph Hellwig wrote: On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: Subject: x86/paravirt: revert exports to restore old behaviour Subdividing the paravirt_ops

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Jeremy Fitzhardinge
Takashi Iwai wrote: I took at this problem (as I have an nvidia card on one of my workstations), and found out that the following suffer from EXPORT_SYMBOL_GPL changes: Which kernel version are you using? This is different in .24-rc compared to .23. * local_disable_irq(),

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-19 Thread Takashi Iwai
At Mon, 19 Nov 2007 17:14:15 -0800, Jeremy Fitzhardinge wrote: Takashi Iwai wrote: I took at this problem (as I have an nvidia card on one of my workstations), and found out that the following suffer from EXPORT_SYMBOL_GPL changes: Which kernel version are you using? This is

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: > NACK, both of these are internal and graphics drivers should not be > using them. > I don't feel very strongly about it either way. I think the two arguments for it are: 1. it's a regression compared to previous kernels 2. it's a visible difference between

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Zachary Amsden
On Tue, 2007-11-13 at 22:22 +, Christoph Hellwig wrote: > On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: > > Subject: x86/paravirt: revert exports to restore old behaviour > > > > Subdividing the paravirt_ops structure caused a regression in certain > > non-GPL modules

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Christoph Hellwig
On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: > Subject: x86/paravirt: revert exports to restore old behaviour > > Subdividing the paravirt_ops structure caused a regression in certain > non-GPL modules which try to use mmu_ops and cpu_ops. This restores > the old

[PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Jeremy Fitzhardinge
Subject: x86/paravirt: revert exports to restore old behaviour Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case. Tobias's mail: >

[PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Jeremy Fitzhardinge
Subject: x86/paravirt: revert exports to restore old behaviour Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case. Tobias's mail:

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Christoph Hellwig
On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: Subject: x86/paravirt: revert exports to restore old behaviour Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour,

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Zachary Amsden
On Tue, 2007-11-13 at 22:22 +, Christoph Hellwig wrote: On Tue, Nov 13, 2007 at 12:21:16PM -0800, Jeremy Fitzhardinge wrote: Subject: x86/paravirt: revert exports to restore old behaviour Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try

Re: [PATCH] x86/paravirt: revert exports to restore old behaviour

2007-11-13 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: NACK, both of these are internal and graphics drivers should not be using them. I don't feel very strongly about it either way. I think the two arguments for it are: 1. it's a regression compared to previous kernels 2. it's a visible difference between