Re: [PATCH] x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU

2018-02-13 Thread Masayoshi Mizuma
uncore_extra_pci_dev[pkg].dev[i] = NULL; > > ... then that creates two _real_ bugs AFAICS: > > 1) we dereference uncore_extra_pci_dev[] with a negative index > > 2) we fail to clean up a stale pointer in uncore_extra_pci_dev[][] > > So I've rewritten your

Re: [PATCH] x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU

2018-02-13 Thread Masayoshi Mizuma
; ... then that creates two _real_ bugs AFAICS: > > 1) we dereference uncore_extra_pci_dev[] with a negative index > > 2) we fail to clean up a stale pointer in uncore_extra_pci_dev[][] > > So I've rewritten your changelog accordingly - see the attached patch. > >

[PATCH] x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU

2018-02-13 Thread Ingo Molnar
e rewritten your changelog accordingly - see the attached patch. I have also added a Cc: stable tag. Thanks, Ingo =======> >From 295cc7eb314eb3321fb6d67ca6f7305f5c50d10f Mon Sep 17 00:00:00 2001 From: Masayoshi Mizuma <m.miz...@jp.fujitsu.com> Date: Thu, 8 Feb 2

[PATCH] x86/smpboot: Fix uncore_pci_remove() indexing bug when hot-removing a physical CPU

2018-02-13 Thread Ingo Molnar
ched patch. I have also added a Cc: stable tag. Thanks, Ingo ===> >From 295cc7eb314eb3321fb6d67ca6f7305f5c50d10f Mon Sep 17 00:00:00 2001 From: Masayoshi Mizuma Date: Thu, 8 Feb 2018 09:19:08 -0500 Subject: [PATCH] x86/smpboot: Fix uncore_pci_remove() indexing bug w