Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Andi Kleen
> > BTW our much worse problems right now are crash reports on several > > stable kernels, especially with large pages > > Do you have any reference? https://lkml.org/lkml/2018/8/17/546 https://bugzilla.redhat.com/show_bug.cgi?id=1618792 (this is 4.17, not 4.18) (might be different

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Andi Kleen
> > BTW our much worse problems right now are crash reports on several > > stable kernels, especially with large pages > > Do you have any reference? https://lkml.org/lkml/2018/8/17/546 https://bugzilla.redhat.com/show_bug.cgi?id=1618792 (this is 4.17, not 4.18) (might be different

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 13:41:03, Vlastimil Babka wrote: > On 08/20/2018 12:49 PM, Michal Hocko wrote: > > On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: > >> On 32bit PAE kernels on 64bit hardware with enough physical bits, > >> l1tf_pfn_limit() will overflow unsigned long. This in turn affects > >>

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 13:41:03, Vlastimil Babka wrote: > On 08/20/2018 12:49 PM, Michal Hocko wrote: > > On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: > >> On 32bit PAE kernels on 64bit hardware with enough physical bits, > >> l1tf_pfn_limit() will overflow unsigned long. This in turn affects > >>

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 07:20:27, Andi Kleen wrote: > On Mon, Aug 20, 2018 at 11:58:35AM +0200, Vlastimil Babka wrote: > > On 32bit PAE kernels on 64bit hardware with enough physical bits, > > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > > max_swapfile_size() and can lead to swapon

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 07:20:27, Andi Kleen wrote: > On Mon, Aug 20, 2018 at 11:58:35AM +0200, Vlastimil Babka wrote: > > On 32bit PAE kernels on 64bit hardware with enough physical bits, > > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > > max_swapfile_size() and can lead to swapon

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Andi Kleen
On Mon, Aug 20, 2018 at 11:58:35AM +0200, Vlastimil Babka wrote: > On 32bit PAE kernels on 64bit hardware with enough physical bits, > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > max_swapfile_size() and can lead to swapon returning -EINVAL. This has been > observed in a

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Andi Kleen
On Mon, Aug 20, 2018 at 11:58:35AM +0200, Vlastimil Babka wrote: > On 32bit PAE kernels on 64bit hardware with enough physical bits, > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > max_swapfile_size() and can lead to swapon returning -EINVAL. This has been > observed in a

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Vlastimil Babka
On 08/20/2018 12:49 PM, Michal Hocko wrote: > On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: >> On 32bit PAE kernels on 64bit hardware with enough physical bits, >> l1tf_pfn_limit() will overflow unsigned long. This in turn affects >> max_swapfile_size() and can lead to swapon returning -EINVAL.

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Vlastimil Babka
On 08/20/2018 12:49 PM, Michal Hocko wrote: > On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: >> On 32bit PAE kernels on 64bit hardware with enough physical bits, >> l1tf_pfn_limit() will overflow unsigned long. This in turn affects >> max_swapfile_size() and can lead to swapon returning -EINVAL.

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: > On 32bit PAE kernels on 64bit hardware with enough physical bits, > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > max_swapfile_size() and can lead to swapon returning -EINVAL. This has been > observed in a 32bit guest with

Re: [PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Michal Hocko
On Mon 20-08-18 11:58:35, Vlastimil Babka wrote: > On 32bit PAE kernels on 64bit hardware with enough physical bits, > l1tf_pfn_limit() will overflow unsigned long. This in turn affects > max_swapfile_size() and can lead to swapon returning -EINVAL. This has been > observed in a 32bit guest with

[PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Vlastimil Babka
On 32bit PAE kernels on 64bit hardware with enough physical bits, l1tf_pfn_limit() will overflow unsigned long. This in turn affects max_swapfile_size() and can lead to swapon returning -EINVAL. This has been observed in a 32bit guest with 42 bits physical address size, where max_swapfile_size()

[PATCH] x86/speculation/l1tf: fix overflow on l1tf_pfn_limit() on 32bit

2018-08-20 Thread Vlastimil Babka
On 32bit PAE kernels on 64bit hardware with enough physical bits, l1tf_pfn_limit() will overflow unsigned long. This in turn affects max_swapfile_size() and can lead to swapon returning -EINVAL. This has been observed in a 32bit guest with 42 bits physical address size, where max_swapfile_size()