Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-10 Thread hpa
On September 10, 2019 7:28:28 AM GMT+01:00, Ingo Molnar wrote: > >* h...@zytor.com wrote: > >> I would strongly suggest that we change the term "emulation" to >> "spoofing" for these instructions. We need to explain that we do >*not* >> execute these instructions the was the CPU would have,

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-10 Thread Ingo Molnar
* h...@zytor.com wrote: > I would strongly suggest that we change the term "emulation" to > "spoofing" for these instructions. We need to explain that we do *not* > execute these instructions the was the CPU would have, and unlike the > native instructions do not leak kernel information.

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-09 Thread Brendan Shanks
> On Sep 7, 2019, at 2:26 PM, Ricardo Neri > wrote: > > On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote: >> >> if (umip_inst == UMIP_INST_SGDT || umip_inst == UMIP_INST_SIDT) { >> +u64 dummy_base_addr; >> +u16 dummy_limit = 0; >> + >>

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-09 Thread hpa
On September 6, 2019 12:22:21 AM GMT+01:00, Brendan Shanks wrote: >Add emulation of the sgdt, sidt, and smsw instructions for 64-bit >processes. > >Wine users have encountered a number of 64-bit Windows games that use >these instructions (particularly sgdt), and were crashing when run on

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-09 Thread hpa
On September 8, 2019 8:22:48 AM GMT+01:00, Borislav Petkov wrote: >On Sat, Sep 07, 2019 at 02:26:10PM -0700, Ricardo Neri wrote: >> > Wine users have encountered a number of 64-bit Windows games that >use >> > these instructions (particularly sgdt), and were crashing when run >on >> >

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-08 Thread Borislav Petkov
On Sat, Sep 07, 2019 at 02:26:10PM -0700, Ricardo Neri wrote: > > Wine users have encountered a number of 64-bit Windows games that use > > these instructions (particularly sgdt), and were crashing when run on > > UMIP-enabled systems. > > Emulation support for 64-bit processes was not initially

Re: [PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-07 Thread Ricardo Neri
On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote: > Add emulation of the sgdt, sidt, and smsw instructions for 64-bit > processes. > > Wine users have encountered a number of 64-bit Windows games that use > these instructions (particularly sgdt), and were crashing when run on >

[PATCH] x86/umip: Add emulation for 64-bit processes

2019-09-05 Thread Brendan Shanks
Add emulation of the sgdt, sidt, and smsw instructions for 64-bit processes. Wine users have encountered a number of 64-bit Windows games that use these instructions (particularly sgdt), and were crashing when run on UMIP-enabled systems. Originally-by: Ricardo Neri Signed-off-by: Brendan