Re: [PATCH] x86/unwind: remove unneeded initialization

2020-10-29 Thread Peter Zijlstra
On Thu, Oct 29, 2020 at 11:49:50AM +, Walter Harms wrote: > this looks like a reimplementation of bsearch() > perhaps the maintainer can add a comment why the > kernel implementation is not suitable here ? If you look carefully it doesn't do an exact match, which is what bsearch() does.

AW: [PATCH] x86/unwind: remove unneeded initialization

2020-10-29 Thread Walter Harms
: [PATCH] x86/unwind: remove unneeded initialization make clang-analyzer on x86_64 defconfig caught my attention with: arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during its initialization is never read [clang-analyzer-deadcode.DeadStores] int *mid = first, *found

Re: [PATCH] x86/unwind: remove unneeded initialization

2020-10-28 Thread Nathan Chancellor
On Wed, Oct 28, 2020 at 01:21:02PM +0100, Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during > its initialization is never read [clang-analyzer-deadcode.DeadStores] >

[PATCH] x86/unwind: remove unneeded initialization

2020-10-28 Thread Lukas Bulwahn
make clang-analyzer on x86_64 defconfig caught my attention with: arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during its initialization is never read [clang-analyzer-deadcode.DeadStores] int *mid = first, *found = first; ^ Commit ee9f8fce9964