On Mon, Nov 25, 2013 at 04:51:59PM -0800, Joe Perches wrote:
> Perhaps you could dial down your humility a bit. Perhaps you'll reread
> and see if it seems humble to you.
So I vivid reader of LKML and I were wondering how you'd react to the
urge from a kernel maintainer to get you to finally
On Mon, 2013-11-25 at 11:18 +0100, Ingo Molnar wrote:
> * Joe Perches wrote:
> > On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
> > > I'll take a proper cleanup,
> > > but just whitespace... just pointless churn.
> > What in your view would be "a proper cleanup" for a20.c?
>
> If a
On Mon, Nov 25, 2013 at 11:18:07AM +0100, Ingo Molnar wrote:
> If a newbie does a meaningful, complete, well done cleanup patch then
> congratulations and any such help is welcome.
>
> If you as a more experienced kernel developer do a cleanup as part of
> some real work then sure, all such
* Joe Perches wrote:
> On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
>
> > I'll take a proper cleanup,
> > but just whitespace... just pointless churn.
>
> What in your view would be "a proper cleanup" for a20.c?
If a newbie does a meaningful, complete, well done cleanup patch then
* Joe Perches j...@perches.com wrote:
On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
I'll take a proper cleanup,
but just whitespace... just pointless churn.
What in your view would be a proper cleanup for a20.c?
If a newbie does a meaningful, complete, well done cleanup
On Mon, Nov 25, 2013 at 11:18:07AM +0100, Ingo Molnar wrote:
If a newbie does a meaningful, complete, well done cleanup patch then
congratulations and any such help is welcome.
If you as a more experienced kernel developer do a cleanup as part of
some real work then sure, all such cleanups
On Mon, 2013-11-25 at 11:18 +0100, Ingo Molnar wrote:
* Joe Perches j...@perches.com wrote:
On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
I'll take a proper cleanup,
but just whitespace... just pointless churn.
What in your view would be a proper cleanup for a20.c?
If a
On Mon, Nov 25, 2013 at 04:51:59PM -0800, Joe Perches wrote:
snip senseless comebacks
Perhaps you could dial down your humility a bit. Perhaps you'll reread
and see if it seems humble to you.
So I vivid reader of LKML and I were wondering how you'd react to the
urge from a kernel maintainer
On Tue, Nov 19, 2013 at 10:45:00AM -0800, H. Peter Anvin wrote:
> I don't know (or even if it needs one,...
Exactly.
With the amount of real bugs/issues *actually* being reported out there,
why would people waste energy on senseless cleanups is beyond me.
a20.c is fine the way it is, it doesn't
On 11/19/2013 10:28 AM, Joe Perches wrote:
> On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
>> I'll take a proper cleanup,
>> but just whitespace... just pointless churn.
>
> What in your view would be "a proper cleanup" for a20.c?
>
I don't know (or even if it needs one, although
On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
> I'll take a proper cleanup,
> but just whitespace... just pointless churn.
What in your view would be "a proper cleanup" for a20.c?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On 11/19/2013 10:23 AM, Borislav Petkov wrote:
> On Tue, Nov 19, 2013 at 09:48:43AM -0800, Joe Perches wrote:
>> git diff -w and git blame -w both ignore whitespace changes and can
>> help in tracking down actual modifications.
>
> That's not the point - I don't want those commits there getting
On Tue, Nov 19, 2013 at 09:48:43AM -0800, Joe Perches wrote:
> git diff -w and git blame -w both ignore whitespace changes and can
> help in tracking down actual modifications.
That's not the point - I don't want those commits there getting in the
way.
If it
* doesn't fix a real bug,
*
On Tue, 2013-11-19 at 11:34 +0100, Borislav Petkov wrote:
> On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
> > * H. Peter Anvin wrote:
> > > On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > > > Replace all mixed indentation with tabs
> > > > Signed-off-by: Johannes Löthberg
> >
On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
>
> * H. Peter Anvin wrote:
>
> > On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > > Replace all mixed indentation with tabs
> > >
> > > Signed-off-by: Johannes Löthberg
> >
> > NAK. Not worth the churn in the absence of other
On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
* H. Peter Anvin h...@zytor.com wrote:
On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg johan...@kyriasis.com
NAK. Not worth the churn in the
On Tue, 2013-11-19 at 11:34 +0100, Borislav Petkov wrote:
On Tue, Nov 19, 2013 at 08:22:41AM +0100, Ingo Molnar wrote:
* H. Peter Anvin h...@zytor.com wrote:
On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg
On Tue, Nov 19, 2013 at 09:48:43AM -0800, Joe Perches wrote:
git diff -w and git blame -w both ignore whitespace changes and can
help in tracking down actual modifications.
That's not the point - I don't want those commits there getting in the
way.
If it
* doesn't fix a real bug,
* doesn't
On 11/19/2013 10:23 AM, Borislav Petkov wrote:
On Tue, Nov 19, 2013 at 09:48:43AM -0800, Joe Perches wrote:
git diff -w and git blame -w both ignore whitespace changes and can
help in tracking down actual modifications.
That's not the point - I don't want those commits there getting in the
On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
I'll take a proper cleanup,
but just whitespace... just pointless churn.
What in your view would be a proper cleanup for a20.c?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On 11/19/2013 10:28 AM, Joe Perches wrote:
On Tue, 2013-11-19 at 10:24 -0800, H. Peter Anvin wrote:
I'll take a proper cleanup,
but just whitespace... just pointless churn.
What in your view would be a proper cleanup for a20.c?
I don't know (or even if it needs one, although Ingo seems to
On Tue, Nov 19, 2013 at 10:45:00AM -0800, H. Peter Anvin wrote:
I don't know (or even if it needs one,...
Exactly.
With the amount of real bugs/issues *actually* being reported out there,
why would people waste energy on senseless cleanups is beyond me.
a20.c is fine the way it is, it doesn't
* H. Peter Anvin wrote:
> On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> > Replace all mixed indentation with tabs
> >
> > Signed-off-by: Johannes Löthberg
>
> NAK. Not worth the churn in the absence of other changes.
Yes.
If a20.c was cleaned up altogether, that might be a more
On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
> Replace all mixed indentation with tabs
>
> Signed-off-by: Johannes Löthberg
NAK. Not worth the churn in the absence of other changes.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg
---
arch/x86/boot/a20.c | 62 ++---
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index 64a31a6..c837ac6 100644
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg johan...@kyriasis.com
---
arch/x86/boot/a20.c | 62 ++---
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
index
On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg johan...@kyriasis.com
NAK. Not worth the churn in the absence of other changes.
-hpa
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
* H. Peter Anvin h...@zytor.com wrote:
On 11/18/2013 09:50 AM, Johannes Löthberg wrote:
Replace all mixed indentation with tabs
Signed-off-by: Johannes Löthberg johan...@kyriasis.com
NAK. Not worth the churn in the absence of other changes.
Yes.
If a20.c was cleaned up altogether,
28 matches
Mail list logo
