Re: [PATCH] x86: fix a bug introduced by "allocate full pt_regs" commit

2015-02-26 Thread Andy Lutomirski
On Thu, Feb 26, 2015 at 6:08 AM, Denys Vlasenko wrote: > If syscall_trace_enter_phase1 returns 0, > code restores %rax from pt_regs->ax, but should restore it from > pt_regs->orig_ax. > > The bug crept in because LOAD_ARGS macro was very sublty different > from RESTORE_ARGS, it had only two

[PATCH] x86: fix a bug introduced by "allocate full pt_regs" commit

2015-02-26 Thread Denys Vlasenko
If syscall_trace_enter_phase1 returns 0, code restores %rax from pt_regs->ax, but should restore it from pt_regs->orig_ax. The bug crept in because LOAD_ARGS macro was very sublty different from RESTORE_ARGS, it had only two callsites and only this one was using that difference. Signed-off-by:

[PATCH] x86: fix a bug introduced by allocate full pt_regs commit

2015-02-26 Thread Denys Vlasenko
If syscall_trace_enter_phase1 returns 0, code restores %rax from pt_regs-ax, but should restore it from pt_regs-orig_ax. The bug crept in because LOAD_ARGS macro was very sublty different from RESTORE_ARGS, it had only two callsites and only this one was using that difference. Signed-off-by:

Re: [PATCH] x86: fix a bug introduced by allocate full pt_regs commit

2015-02-26 Thread Andy Lutomirski
On Thu, Feb 26, 2015 at 6:08 AM, Denys Vlasenko dvlas...@redhat.com wrote: If syscall_trace_enter_phase1 returns 0, code restores %rax from pt_regs-ax, but should restore it from pt_regs-orig_ax. The bug crept in because LOAD_ARGS macro was very sublty different from RESTORE_ARGS, it had